Skip to content
GitLab

Suggest another port when 3000 is busy

Merged Administrator requested to merge port into master

Created by: gaearon

I’m taking #101 and adding some minor refactoring on top. I will merge without squashing so original author commits are preserved.

Loading
Loading

Activity

  • Administrator
    Administrator @root ·
    Author Contributor

    Created by: gaearon

    (I will probably squash first several commits though)

  • Administrator
    Administrator @root ·
    Author Contributor

    Created by: chocnut

    @gaearon afaik with #101 the e2e failed because it can't find the newly created utilities/prompt.js wonder why tho haven't check. just get back today. seems like you're changing it already so I'll hold any commit now. thanks!

  • Administrator
    Administrator @root ·
    Author Contributor

    Created by: gaearon

    @chocnut Thanks, this is really good for now! I think it was failing because of regex replacement of any numbers in entry points—which happened to replace parts of test directory paths on CI :smile: . I’m currently looking into another approach to this. I made webpack configs parameterizable, but to be honest, I want to find a way to get rid of port/host in configs completely if possible.

  • Administrator
    Administrator @root ·
    Author Contributor

    Merged by: gaearon at 2016-07-27 20:23:08 UTC

Please register or sign in to reply