Skip to content
GitLab

Fix incorrect check if CI variable is set to true

Merged Administrator requested to merge github/fork/varnav/patch-1 into master

Created by: varnav

Originally build would fail on warnings with any value of CI environment variable. Now it will correctly check if it's true.

Discussed here: https://github.com/facebookincubator/create-react-app/issues/2453

Did a simple test with this shell script:

CI='true'
echo $CI
node -e "if (process.env.CI && process.env.CI.toLowerCase() === 'true') console.log('Yes')"

CI='True'
echo $CI
node -e "if (process.env.CI && process.env.CI.toLowerCase() === 'true') console.log('Yes')"

CI='false'
echo $CI
node -e "if (process.env.CI && process.env.CI.toLowerCase() === 'true') console.log('Yes')"

unset CI
echo $CI
node -e "if (process.env.CI && process.env.CI.toLowerCase() === 'true') console.log('Yes')"