Skip to content
GitLab

Send proper error response upon proxy error

Merged Administrator requested to merge github/fork/cloudmu/master into master

Created by: cloudmu

Currently the custom onError handler for httpProxyMiddleware only logs proxy error on the console (#502). This amends the onError handler so it will also send proper error response to the client.

Otherwise the client will wait for the response and eventually timeout with ERR_EMPTY_RESPONSE, instead of the proper proxy error. See two screenshots before/after this PR.

  1. No proper error response (timeout after up to 2 min): noerrorreponse

  2. Proper error response (with this PR): immediate500reponse

    Note the error response to the client also mirrors the error logged on the dev console: Proxy error: Could not proxy request /api/login from localhost:3000 to http://localhost:3001 (ECONNREFUSED).