Mark TypeScript as an optional peer dependency for react-scripts

Created by: dstaley

This PR adds TypeScript as an optional peer dependency for react-scripts. This modification is necessary to get react-scripts working with Yarn v2, and will enable the TypeScript template for create-react-app to work with Yarn v2.

This PR uses the peerDependenciesMeta key, which signifies to Yarn that typescript is an optional dependency. npm will support the key in the future, in which case "typescript": "*" can be added to peerDependencies. Until that change is made, simply having peerDependenciesMeta will be enough for Yarn, and won't adversely impact users of npm.

Other relevant issues: yarnpkg/berry/pull/475

/cc @iansu

requested review from @root

requested review from @root

requested review from @root

requested review from @root

Created by: facebook-github-bot

Hi dstaley! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

Created by: iansu

@dstaley Awesome! I suppose we'll have to publish this change to get the tests passing in Yarn v2? I can merge this right away but it might not be published for a week or two as we're currently working on the next release.

Created by: dstaley

@iansu yeah, we'd need npx create-react-app to result in the new version being installed for the tests. It's okay if it waits for the next release! I can setup a reminder to check every couple of days to see if the new release has been published.

added CLA Signed label

Created by: facebook-github-bot

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

added tag: bug fix label

changed milestone to %3.3

Merged by: ianschmitz at 2019-10-31 04:05:30 UTC

closed

Created by: ianschmitz

Thanks @dstaley!