Created by: skovhus
Fixes https://github.com/facebook/create-react-app/issues/8361, fixes #8689 (closed), fixes #7491 (closed).
QA
I hope that CI will ensure that Jest 25 works.
But I'm wondering what is the best way to try link react-script into an existing application and try it out? I'll try to verify that the suggested changes will work with the CRA-powered apps that I'm currently working on.
Activity
requested review from @root
requested review from @root
requested review from @root
requested review from @root
added CLA Signed label
Created by: ianschmitz
Can/should we make the jsdom version configurable?
You can use
--env
to configure the environment, including using a different version of jsdom via one of the support packages (https://www.npmjs.com/package/jest-environment-jsdom-fifteen, etc)Created by: ianschmitz
Hmm.. Now that i think about it we may be able to upgrade to Jest 25, but force it onto the older version of jsdom by default, while still offering the option for folks to opt-in to the newest jsdom via the support package and the
--env
flag.Let me put some thought into this. I'll check it out to see if there's any compat issues with newer jest + old jsdom.
mentioned in merge request !8532 (closed)
added stale label
removed stale label