Created by: ehsankhfr
Fix #9986 (closed)
With the current node-sass
version (v5), react-script
won't survive.
TEST PLAN
With the sass-loader
version upgrade and new version of node-sass
:
npx create-react-app sass-error-compilation
cd sass-error-compilation
yarn add node-sass@5.0.0
- Modify App.css to App.scss. Change extension in App.js as well.
- change the sass-loader version in
node_modules/react-scripts/package.json
to^10.0.5
yarn add sass-loader@10.0.5
yarn start
- Should work successfully
With the sass-loader
version upgrade and old version of node-sass
:
npx create-react-app sass-error-compilation
cd sass-error-compilation
yarn add node-sass@4.14.1
- Modify App.css to App.scss. Change extension in App.js as well.
- change the sass-loader version in
node_modules/react-scripts/package.json
to^10.0.5
yarn add sass-loader@10.0.5
yarn start
- Should work successfully
Without the version upgrade and and new version of node-sass
:
npx create-react-app sass-error-compilation
cd sass-error-compilation
yarn add node-sass@5.0.0
- Modify App.css to App.scss. Change extension in App.js as well.
yarn start
- Should fail to run with version incompatibility error