• Jon Wolski's avatar
    Remove `color` property from `badge` class · f07d8703
    Jon Wolski authored
    I suggest removing `color: #FFF` from the `badge` class, because it is
    provided by the `badge-<modifier>` classes along with a
    background-color, whereas there is no corresponding background-color
    provided on the `badge` class itself.
    
    Background
    ----------
    
    According to the documentation:
    
    > [badge] Requires one of the contextual, color modifier classes for `color` and
    > `background-color`.
    
    That is, color and background color should be provided by a modifier
    class, rather than the badge class itself.
    
    e.g. `<span class='badge badge-primary'>4</span>`
    
    In general, providing a `color` property without also providing a
    `background-color` should be avoided. [W3 QA tips]
    
    In this context, this is a problem only if someone creates a `badge`
    without providing a modifier. Such an omition may be difficult to trouble-shoot,
    because this will most likely yield white text on a white background.
    
    [W3 QA tips](https://www.w3.org/QA/Tips/color)
    Unverified
    f07d8703