Skip to content
GitLab
Projects
Groups
Snippets
/
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
Menu
Open sidebar
Bootstrap
bootstrap
Commits
088c727a
Commit
088c727a
authored
4 years ago
by
Johann-S
Browse files
Options
Download
Email Patches
Plain Diff
data: reword storage key in dom
parent
5ad43fec
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
js/src/dom/data.js
+8
-8
js/src/dom/data.js
js/tests/unit/dom/data.spec.js
+7
-7
js/tests/unit/dom/data.spec.js
with
15 additions
and
15 deletions
+15
-15
js/src/dom/data.js
+
8
-
8
View file @
088c727a
...
@@ -16,22 +16,22 @@ const mapData = (() => {
...
@@ -16,22 +16,22 @@ const mapData = (() => {
let
id
=
1
let
id
=
1
return
{
return
{
set
(
element
,
key
,
data
)
{
set
(
element
,
key
,
data
)
{
if
(
typeof
element
.
k
ey
===
'
undefined
'
)
{
if
(
typeof
element
.
bsK
ey
===
'
undefined
'
)
{
element
.
k
ey
=
{
element
.
bsK
ey
=
{
key
,
key
,
id
id
}
}
id
++
id
++
}
}
storeData
[
element
.
k
ey
.
id
]
=
data
storeData
[
element
.
bsK
ey
.
id
]
=
data
},
},
get
(
element
,
key
)
{
get
(
element
,
key
)
{
if
(
!
element
||
typeof
element
.
k
ey
===
'
undefined
'
)
{
if
(
!
element
||
typeof
element
.
bsK
ey
===
'
undefined
'
)
{
return
null
return
null
}
}
const
keyProperties
=
element
.
k
ey
const
keyProperties
=
element
.
bsK
ey
if
(
keyProperties
.
key
===
key
)
{
if
(
keyProperties
.
key
===
key
)
{
return
storeData
[
keyProperties
.
id
]
return
storeData
[
keyProperties
.
id
]
}
}
...
@@ -39,14 +39,14 @@ const mapData = (() => {
...
@@ -39,14 +39,14 @@ const mapData = (() => {
return
null
return
null
},
},
delete
(
element
,
key
)
{
delete
(
element
,
key
)
{
if
(
typeof
element
.
k
ey
===
'
undefined
'
)
{
if
(
typeof
element
.
bsK
ey
===
'
undefined
'
)
{
return
return
}
}
const
keyProperties
=
element
.
k
ey
const
keyProperties
=
element
.
bsK
ey
if
(
keyProperties
.
key
===
key
)
{
if
(
keyProperties
.
key
===
key
)
{
delete
storeData
[
keyProperties
.
id
]
delete
storeData
[
keyProperties
.
id
]
delete
element
.
k
ey
delete
element
.
bsK
ey
}
}
}
}
}
}
...
...
This diff is collapsed.
Click to expand it.
js/tests/unit/dom/data.spec.js
+
7
-
7
View file @
088c727a
...
@@ -15,7 +15,7 @@ describe('Data', () => {
...
@@ -15,7 +15,7 @@ describe('Data', () => {
})
})
describe
(
'
setData
'
,
()
=>
{
describe
(
'
setData
'
,
()
=>
{
it
(
'
should set data in an element by adding a
k
ey attribute
'
,
()
=>
{
it
(
'
should set data in an element by adding a
bsK
ey attribute
'
,
()
=>
{
fixtureEl
.
innerHTML
=
'
<div></div>
'
fixtureEl
.
innerHTML
=
'
<div></div>
'
const
div
=
fixtureEl
.
querySelector
(
'
div
'
)
const
div
=
fixtureEl
.
querySelector
(
'
div
'
)
...
@@ -24,7 +24,7 @@ describe('Data', () => {
...
@@ -24,7 +24,7 @@ describe('Data', () => {
}
}
Data
.
setData
(
div
,
'
test
'
,
data
)
Data
.
setData
(
div
,
'
test
'
,
data
)
expect
(
div
.
k
ey
).
toBeDefined
()
expect
(
div
.
bsK
ey
).
toBeDefined
()
})
})
it
(
'
should change data if something is already stored
'
,
()
=>
{
it
(
'
should change data if something is already stored
'
,
()
=>
{
...
@@ -40,7 +40,7 @@ describe('Data', () => {
...
@@ -40,7 +40,7 @@ describe('Data', () => {
data
.
test
=
'
bsData2
'
data
.
test
=
'
bsData2
'
Data
.
setData
(
div
,
'
test
'
,
data
)
Data
.
setData
(
div
,
'
test
'
,
data
)
expect
(
div
.
k
ey
).
toBeDefined
()
expect
(
div
.
bsK
ey
).
toBeDefined
()
})
})
})
})
...
@@ -104,11 +104,11 @@ describe('Data', () => {
...
@@ -104,11 +104,11 @@ describe('Data', () => {
Data
.
setData
(
div
,
'
test
'
,
data
)
Data
.
setData
(
div
,
'
test
'
,
data
)
expect
(
div
.
k
ey
).
toBeDefined
()
expect
(
div
.
bsK
ey
).
toBeDefined
()
Data
.
removeData
(
div
,
'
test2
'
)
Data
.
removeData
(
div
,
'
test2
'
)
expect
(
div
.
k
ey
).
toBeDefined
()
expect
(
div
.
bsK
ey
).
toBeDefined
()
})
})
it
(
'
should remove data if something is stored
'
,
()
=>
{
it
(
'
should remove data if something is stored
'
,
()
=>
{
...
@@ -121,11 +121,11 @@ describe('Data', () => {
...
@@ -121,11 +121,11 @@ describe('Data', () => {
Data
.
setData
(
div
,
'
test
'
,
data
)
Data
.
setData
(
div
,
'
test
'
,
data
)
expect
(
div
.
k
ey
).
toBeDefined
()
expect
(
div
.
bsK
ey
).
toBeDefined
()
Data
.
removeData
(
div
,
'
test
'
)
Data
.
removeData
(
div
,
'
test
'
)
expect
(
div
.
k
ey
).
toBeUndefined
()
expect
(
div
.
bsK
ey
).
toBeUndefined
()
})
})
})
})
})
})
This diff is collapsed.
Click to expand it.
Write
Preview
Supports
Markdown
0%
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment