From 09019a8ecdccf61b52681dec3376a88509b4e6a3 Mon Sep 17 00:00:00 2001
From: Mark Otto <markdotto@gmail.com>
Date: Sat, 17 Jun 2017 21:19:36 -0700
Subject: [PATCH] Set explicit text-align on <body> element so we can use
inherit to override the default <th> text-align value
---
docs/4.0/content/reboot.md | 2 +-
scss/_reboot.scss | 8 ++++++--
2 files changed, 7 insertions(+), 3 deletions(-)
diff --git a/docs/4.0/content/reboot.md b/docs/4.0/content/reboot.md
index 7565bb41a7..f42332874e 100644
--- a/docs/4.0/content/reboot.md
+++ b/docs/4.0/content/reboot.md
@@ -24,7 +24,7 @@ The `<html>` and `<body>` elements are updated to provide better page-wide defau
- The `box-sizing` is globally set on every element—including `*:before` and `*:after`, to `border-box`. This ensures that the declared width of element is never exceeded due to padding or border.
- No base `font-size` is declared on the `<html>`, but `16px` is assumed (the browser default). `font-size: 1rem` is applied on the `<body>` for easy responsive type-scaling via media queries while respecting user preferences and ensuring a more accessible approach.
-- The `<body>` also sets a global `font-family` and `line-height`. This is inherited later by some form elements to prevent font inconsistencies.
+- The `<body>` also sets a global `font-family`, `line-height`, and `text-align`. This is inherited later by some form elements to prevent font inconsistencies.
- For safety, the `<body>` has a declared `background-color`, defaulting to `#fff`.
## Native font stack
diff --git a/scss/_reboot.scss b/scss/_reboot.scss
index 33fc2d660a..2adedda60d 100644
--- a/scss/_reboot.scss
+++ b/scss/_reboot.scss
@@ -48,6 +48,8 @@ article, aside, dialog, figcaption, figure, footer, header, hgroup, main, nav, s
//
// 1. Remove the margin in all browsers.
// 2. As a best practice, apply a default `background-color`.
+// 3. Set an explicit initial text-align value so that we can later use the
+// the `inherit` value on things like `<th>` elements.
body {
margin: 0; // 1
@@ -56,6 +58,7 @@ body {
font-weight: $font-weight-base;
line-height: $line-height-base;
color: $body-color;
+ text-align: left; // 3
background-color: $body-bg; // 2
}
@@ -304,8 +307,9 @@ caption {
}
th {
- // Matches default `<td>` alignment
- text-align: left;
+ // Matches default `<td>` alignment by inheriting from the `<body>`, or the
+ // closest parent with a set `text-align`.
+ text-align: inherit;
}
--
GitLab