Skip to content
GitLab
Explore
Projects
Groups
Snippets
Projects
Groups
Snippets
/
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
Menu
Open sidebar
Bootstrap
bootstrap
Commits
0b719e06
Commit
0b719e06
authored
6 years ago
by
Johann-S
Committed by
XhmikosR
6 years ago
Browse files
Options
Download
Email Patches
Plain Diff
fix(data): increase coverage for data
parent
93134462
5 merge requests
!31948
Examples/Floating-labels: fix bad behavior with autofill
,
!30064
test
,
!29779
Responsive sizing
,
!28882
fix custom-select-indicator in IE10
,
!28721
Hot test
Changes
4
Hide whitespace changes
Inline
Side-by-side
Showing
4 changed files
js/src/dom/data.js
+1
-2
js/src/dom/data.js
js/tests/karma.conf.js
+14
-4
js/tests/karma.conf.js
js/tests/unit/.eslintrc.json
+1
-0
js/tests/unit/.eslintrc.json
js/tests/unit/dom/data.js
+83
-0
js/tests/unit/dom/data.js
with
99 additions
and
6 deletions
+99
-6
js/src/dom/data.js
+
1
-
2
View file @
0b719e06
/**
* --------------------------------------------------------------------------
* Bootstrap (v4.
0.0-beta
): dom/data.js
* Bootstrap (v4.
1.1
): dom/data.js
* Licensed under MIT (https://github.com/twbs/bootstrap/blob/master/LICENSE)
* --------------------------------------------------------------------------
*/
...
...
@@ -12,7 +12,6 @@ const Data = (() => {
* ------------------------------------------------------------------------
*/
const
mapData
=
(()
=>
{
const
storeData
=
{}
let
id
=
1
...
...
This diff is collapsed.
Click to expand it.
js/tests/karma.conf.js
+
14
-
4
View file @
0b719e06
...
...
@@ -93,9 +93,16 @@ if (bundle) {
reporters
.
push
(
'
BrowserStack
'
)
files
=
files
.
concat
([
'
node_modules/jquery/dist/jquery.slim.min.js
'
,
'
js/dist/util.js
'
,
'
js/dist/tooltip.js
'
,
'
js/dist/!(util|index|tooltip).js
'
// include all of our js/dist files except util.js, index.js and tooltip.js
'
js/coverage/dist/dom/eventHandler.js
'
,
'
js/coverage/dist/dom/selectorEngine.js
'
,
'
js/coverage/dist/dom/data.js
'
,
'
js/coverage/dist/dom/manipulator.js
'
,
'
js/coverage/dist/util.js
'
,
'
js/coverage/dist/dom/*.js
'
,
'
js/coverage/dist/tooltip.js
'
,
'
js/coverage/dist/!(util|index|tooltip).js
'
,
// include all of our js/dist files except util.js, index.js and tooltip.js
'
js/tests/unit/*.js
'
,
'
js/tests/unit/dom/*.js
'
])
}
else
{
frameworks
.
push
(
'
detectBrowsers
'
)
...
...
@@ -112,8 +119,11 @@ if (bundle) {
'
js/coverage/dist/dom/data.js
'
,
'
js/coverage/dist/dom/manipulator.js
'
,
'
js/coverage/dist/util.js
'
,
'
js/coverage/dist/dom/*.js
'
,
'
js/coverage/dist/tooltip.js
'
,
'
js/coverage/dist/!(util|index|tooltip).js
'
// include all of our js/dist files except util.js, index.js and tooltip.js
'
js/coverage/dist/!(util|index|tooltip).js
'
,
// include all of our js/dist files except util.js, index.js and tooltip.js
'
js/tests/unit/*.js
'
,
'
js/tests/unit/dom/*.js
'
])
reporters
.
push
(
'
coverage-istanbul
'
)
conf
.
customLaunchers
=
customLaunchers
...
...
This diff is collapsed.
Click to expand it.
js/tests/unit/.eslintrc.json
+
1
-
0
View file @
0b719e06
...
...
@@ -8,6 +8,7 @@
"bootstrap"
:
false
,
"sinon"
:
false
,
"Util"
:
false
,
"Data"
:
false
,
"Alert"
:
false
,
"Button"
:
false
,
"Carousel"
:
false
,
...
...
This diff is collapsed.
Click to expand it.
js/tests/unit/dom/data.js
0 → 100644
+
83
-
0
View file @
0b719e06
$
(
function
()
{
'
use strict
'
QUnit
.
module
(
'
data
'
)
QUnit
.
test
(
'
should be defined
'
,
function
(
assert
)
{
assert
.
expect
(
1
)
assert
.
ok
(
Data
,
'
Data is defined
'
)
})
QUnit
.
test
(
'
should set data in a element
'
,
function
(
assert
)
{
assert
.
expect
(
1
)
var
$div
=
$
(
'
<div />
'
).
appendTo
(
'
#qunit-fixture
'
)
var
data
=
{
test
:
'
bsData
'
}
Data
.
setData
(
$div
[
0
],
'
test
'
,
data
)
assert
.
ok
(
$div
[
0
].
key
,
'
element have a data key
'
)
})
QUnit
.
test
(
'
should get data from an element
'
,
function
(
assert
)
{
assert
.
expect
(
1
)
var
$div
=
$
(
'
<div />
'
).
appendTo
(
'
#qunit-fixture
'
)
var
data
=
{
test
:
'
bsData
'
}
Data
.
setData
(
$div
[
0
],
'
test
'
,
data
)
assert
.
strictEqual
(
Data
.
getData
(
$div
[
0
],
'
test
'
),
data
)
})
QUnit
.
test
(
'
should return null if nothing is stored
'
,
function
(
assert
)
{
assert
.
expect
(
1
)
assert
.
ok
(
Data
.
getData
(
document
.
body
,
'
test
'
)
===
null
)
})
QUnit
.
test
(
'
should return null if nothing is stored with an existing key
'
,
function
(
assert
)
{
assert
.
expect
(
1
)
var
$div
=
$
(
'
<div />
'
).
appendTo
(
'
#qunit-fixture
'
)
$div
[
0
].
key
=
{
key
:
'
test2
'
,
data
:
'
woot woot
'
}
assert
.
ok
(
Data
.
getData
(
$div
[
0
],
'
test
'
)
===
null
)
})
QUnit
.
test
(
'
should delete data
'
,
function
(
assert
)
{
assert
.
expect
(
2
)
var
$div
=
$
(
'
<div />
'
).
appendTo
(
'
#qunit-fixture
'
)
var
data
=
{
test
:
'
bsData
'
}
Data
.
setData
(
$div
[
0
],
'
test
'
,
data
)
assert
.
ok
(
Data
.
getData
(
$div
[
0
],
'
test
'
)
!==
null
)
Data
.
removeData
(
$div
[
0
],
'
test
'
)
assert
.
ok
(
Data
.
getData
(
$div
[
0
],
'
test
'
)
===
null
)
})
QUnit
.
test
(
'
should delete nothing if there are nothing
'
,
function
(
assert
)
{
assert
.
expect
(
0
)
Data
.
removeData
(
document
.
body
,
'
test
'
)
})
QUnit
.
test
(
'
should delete nothing if not the good key
'
,
function
(
assert
)
{
assert
.
expect
(
0
)
var
$div
=
$
(
'
<div />
'
).
appendTo
(
'
#qunit-fixture
'
)
$div
[
0
].
key
=
{
key
:
'
test2
'
,
data
:
'
woot woot
'
}
Data
.
removeData
(
$div
[
0
],
'
test
'
)
})
})
This diff is collapsed.
Click to expand it.
Write
Preview
Supports
Markdown
0%
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment
Menu
Explore
Projects
Groups
Snippets