Skip to content
GitLab
Explore
Projects
Groups
Snippets
Projects
Groups
Snippets
/
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
Menu
Open sidebar
Bootstrap
bootstrap
Commits
29460b20
Commit
29460b20
authored
7 years ago
by
Patrick H. Lauke
Committed by
GitHub
7 years ago
Browse files
Options
Download
Plain Diff
Remove inappropriate role="listbox" from carousels
Closes
#22061
Xref #22365
parents
eae1d387
53b2c552
7 merge requests
!28721
Hot test
,
!27561
Adds font-weight-medium to font weight classes
,
!22598
test
,
!25326
Adjust examples
,
!23995
Add back cursor: pointer for .btn-link
,
!23178
Spinner
,
!17021
v4
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
docs/components/carousel.md
+4
-4
docs/components/carousel.md
docs/examples/carousel/index.html
+1
-1
docs/examples/carousel/index.html
js/tests/visual/carousel.html
+1
-1
js/tests/visual/carousel.html
with
6 additions
and
6 deletions
+6
-6
docs/components/carousel.md
+
4
-
4
View file @
29460b20
...
...
@@ -28,7 +28,7 @@ Here's a carousel with slides only. Note the presence of the `.d-block` and `.im
{% example html %}
<div
id=
"carouselExampleSlidesOnly"
class=
"carousel slide"
data-ride=
"carousel"
>
<div
class=
"carousel-inner"
role=
"listbox"
>
<div
class=
"carousel-inner"
>
<div
class=
"carousel-item active"
>
<img
class=
"d-block w-100"
data-src=
"holder.js/800x400?auto=yes&bg=777&fg=555&text=First slide"
alt=
"First slide"
>
</div>
...
...
@@ -48,7 +48,7 @@ Adding in the previous and next controls:
{% example html %}
<div
id=
"carouselExampleControls"
class=
"carousel slide"
data-ride=
"carousel"
>
<div
class=
"carousel-inner"
role=
"listbox"
>
<div
class=
"carousel-inner"
>
<div
class=
"carousel-item active"
>
<img
class=
"d-block w-100"
data-src=
"holder.js/800x400?auto=yes&bg=777&fg=555&text=First slide"
alt=
"First slide"
>
</div>
...
...
@@ -81,7 +81,7 @@ You can also add the indicators to the carousel, alongside the controls, too.
<li
data-target=
"#carouselExampleIndicators"
data-slide-to=
"1"
></li>
<li
data-target=
"#carouselExampleIndicators"
data-slide-to=
"2"
></li>
</ol>
<div
class=
"carousel-inner"
role=
"listbox"
>
<div
class=
"carousel-inner"
>
<div
class=
"carousel-item active"
>
<img
class=
"d-block w-100"
data-src=
"holder.js/800x400?auto=yes&bg=777&fg=555&text=First slide"
alt=
"First slide"
>
</div>
...
...
@@ -120,7 +120,7 @@ Add captions to your slides easily with the `.carousel-caption` element within a
<li
data-target=
"#carouselExampleCaptions"
data-slide-to=
"1"
></li>
<li
data-target=
"#carouselExampleCaptions"
data-slide-to=
"2"
></li>
</ol>
<div
class=
"carousel-inner"
role=
"listbox"
>
<div
class=
"carousel-inner"
>
<div
class=
"carousel-item active"
>
<img
class=
"d-block w-100"
data-src=
"holder.js/800x400?auto=yes&bg=777&fg=555&text=First slide"
alt=
"First slide"
>
<div
class=
"carousel-caption d-none d-md-block"
>
...
...
This diff is collapsed.
Click to expand it.
docs/examples/carousel/index.html
+
1
-
1
View file @
29460b20
...
...
@@ -47,7 +47,7 @@
<li
data-target=
"#myCarousel"
data-slide-to=
"1"
></li>
<li
data-target=
"#myCarousel"
data-slide-to=
"2"
></li>
</ol>
<div
class=
"carousel-inner"
role=
"listbox"
>
<div
class=
"carousel-inner"
>
<div
class=
"carousel-item active"
>
<img
class=
"first-slide"
src=
"data:image/gif;base64,R0lGODlhAQABAIAAAHd3dwAAACH5BAAAAAAALAAAAAABAAEAAAICRAEAOw=="
alt=
"First slide"
>
<div
class=
"container"
>
...
...
This diff is collapsed.
Click to expand it.
js/tests/visual/carousel.html
+
1
-
1
View file @
29460b20
...
...
@@ -18,7 +18,7 @@
<li
data-target=
"#carousel-example-generic"
data-slide-to=
"1"
></li>
<li
data-target=
"#carousel-example-generic"
data-slide-to=
"2"
></li>
</ol>
<div
class=
"carousel-inner"
role=
"listbox"
>
<div
class=
"carousel-inner"
>
<div
class=
"carousel-item active"
>
<img
src=
"https://37.media.tumblr.com/tumblr_m8tay0JcfG1qa42jro1_1280.jpg"
alt=
"First slide"
>
</div>
...
...
This diff is collapsed.
Click to expand it.
Write
Preview
Supports
Markdown
0%
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment
Menu
Explore
Projects
Groups
Snippets