Merge pull request #18148 from jontewks/patch-2

Adds linting error for undefined variables

Merge pull request #18148 from jontewks/patch-2
Adds linting error for undefined variables
4d17a04a · Chris Rebert · 083ef3fd · 2d87ec9a · 4d17a04a · 4d17a04a
Commit 4d17a04a authored 9 years ago by Chris Rebert
Hide whitespace changes
Inline Side-by-side

Showing

with 6 additions and 3 deletions
+6 -3
--- a/js/.eslintrc
+++ b/js/.eslintrc
@@ -2,7 +2,8 @@
    "root": true,
    "parser": "babel-eslint",
    "env": {
-        "browser": true
+        "browser": true,
+        "jquery": true
    },
    "rules": {

@@ -98,7 +99,7 @@
        "no-label-var": 2,
        "no-shadow": 0,
        "no-shadow-restricted-names": 2,
-        "no-undef": 0,
+        "no-undef": 2,
        "no-undefined": 0,
        "no-undef-init": 2,
        "no-unused-vars": 2,

--- a/js/src/modal.js
+++ b/js/src/modal.js
@@ -138,7 +138,7 @@ const Modal = (($) => {
      $(this._dialog).on(Event.MOUSEDOWN_DISMISS, () => {
        $(this._element).one(Event.MOUSEUP_DISMISS, (event) => {
          if ($(event.target).is(this._element)) {
-            that._ignoreBackdropClick = true
+            this._ignoreBackdropClick = true
          }
        })
      })

--- a/js/src/tooltip.js
+++ b/js/src/tooltip.js
+/* global Tether */
+
 import Util from './util'