Skip to content
GitLab
Projects
Groups
Snippets
/
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
Menu
Open sidebar
Bootstrap
bootstrap
Commits
5b401a8c
Commit
5b401a8c
authored
12 years ago
by
Jacob Thornton
Browse files
Options
Download
Email Patches
Plain Diff
add collapsed class to collapse invoker when it's target is collapsed
#3525
parent
5e5965ca
Changes
5
Expand all
Hide whitespace changes
Inline
Side-by-side
Showing
5 changed files
docs/assets/js/bootstrap-collapse.js
+1
-0
docs/assets/js/bootstrap-collapse.js
docs/assets/js/bootstrap.js
+1
-0
docs/assets/js/bootstrap.js
docs/assets/js/bootstrap.min.js
+1
-1
docs/assets/js/bootstrap.min.js
js/bootstrap-collapse.js
+2
-1
js/bootstrap-collapse.js
js/tests/unit/bootstrap-collapse.js
+36
-2
js/tests/unit/bootstrap-collapse.js
with
41 additions
and
4 deletions
+41
-4
docs/assets/js/bootstrap-collapse.js
+
1
-
0
View file @
5b401a8c
...
@@ -150,6 +150,7 @@
...
@@ -150,6 +150,7 @@
||
e
.
preventDefault
()
||
e
.
preventDefault
()
||
(
href
=
$this
.
attr
(
'
href
'
))
&&
href
.
replace
(
/.*
(?=
#
[^\s]
+$
)
/
,
''
)
//strip for ie7
||
(
href
=
$this
.
attr
(
'
href
'
))
&&
href
.
replace
(
/.*
(?=
#
[^\s]
+$
)
/
,
''
)
//strip for ie7
,
option
=
$
(
target
).
data
(
'
collapse
'
)
?
'
toggle
'
:
$this
.
data
()
,
option
=
$
(
target
).
data
(
'
collapse
'
)
?
'
toggle
'
:
$this
.
data
()
$this
[
$
(
target
).
hasClass
(
'
in
'
)
?
'
removeClass
'
:
'
addClass
'
](
'
show
'
)
$
(
target
).
collapse
(
option
)
$
(
target
).
collapse
(
option
)
})
})
})
})
...
...
This diff is collapsed.
Click to expand it.
docs/assets/js/bootstrap.js
+
1
-
0
View file @
5b401a8c
...
@@ -562,6 +562,7 @@
...
@@ -562,6 +562,7 @@
||
e
.
preventDefault
()
||
e
.
preventDefault
()
||
(
href
=
$this
.
attr
(
'
href
'
))
&&
href
.
replace
(
/.*
(?=
#
[^\s]
+$
)
/
,
''
)
//strip for ie7
||
(
href
=
$this
.
attr
(
'
href
'
))
&&
href
.
replace
(
/.*
(?=
#
[^\s]
+$
)
/
,
''
)
//strip for ie7
,
option
=
$
(
target
).
data
(
'
collapse
'
)
?
'
toggle
'
:
$this
.
data
()
,
option
=
$
(
target
).
data
(
'
collapse
'
)
?
'
toggle
'
:
$this
.
data
()
$this
[
$
(
target
).
hasClass
(
'
in
'
)
?
'
removeClass
'
:
'
addClass
'
](
'
show
'
)
$
(
target
).
collapse
(
option
)
$
(
target
).
collapse
(
option
)
})
})
})
})
...
...
This diff is collapsed.
Click to expand it.
docs/assets/js/bootstrap.min.js
+
1
-
1
View file @
5b401a8c
This diff is collapsed.
Click to expand it.
js/bootstrap-collapse.js
+
2
-
1
View file @
5b401a8c
...
@@ -144,12 +144,13 @@
...
@@ -144,12 +144,13 @@
* ==================== */
* ==================== */
$
(
function
()
{
$
(
function
()
{
$
(
'
body
'
).
on
(
'
click.collapse.data-api
'
,
'
[data-toggle=collapse]
'
,
function
(
e
)
{
$
(
'
body
'
).
on
(
'
click.collapse.data-api
'
,
'
[data-toggle=collapse]
'
,
function
(
e
)
{
var
$this
=
$
(
this
),
href
var
$this
=
$
(
this
),
href
,
target
=
$this
.
attr
(
'
data-target
'
)
,
target
=
$this
.
attr
(
'
data-target
'
)
||
e
.
preventDefault
()
||
e
.
preventDefault
()
||
(
href
=
$this
.
attr
(
'
href
'
))
&&
href
.
replace
(
/.*
(?=
#
[^\s]
+$
)
/
,
''
)
//strip for ie7
||
(
href
=
$this
.
attr
(
'
href
'
))
&&
href
.
replace
(
/.*
(?=
#
[^\s]
+$
)
/
,
''
)
//strip for ie7
,
option
=
$
(
target
).
data
(
'
collapse
'
)
?
'
toggle
'
:
$this
.
data
()
,
option
=
$
(
target
).
data
(
'
collapse
'
)
?
'
toggle
'
:
$this
.
data
()
$this
[
$
(
target
).
hasClass
(
'
in
'
)
?
'
addClass
'
:
'
removeClass
'
](
'
collapsed
'
)
$
(
target
).
collapse
(
option
)
$
(
target
).
collapse
(
option
)
})
})
})
})
...
...
This diff is collapsed.
Click to expand it.
js/tests/unit/bootstrap-collapse.js
+
36
-
2
View file @
5b401a8c
...
@@ -24,7 +24,7 @@ $(function () {
...
@@ -24,7 +24,7 @@ $(function () {
test
(
"
should not fire shown when show is prevented
"
,
function
()
{
test
(
"
should not fire shown when show is prevented
"
,
function
()
{
$
.
support
.
transition
=
false
$
.
support
.
transition
=
false
stop
()
;
stop
()
$
(
'
<div class="collapse"/>
'
)
$
(
'
<div class="collapse"/>
'
)
.
bind
(
'
show
'
,
function
(
e
)
{
.
bind
(
'
show
'
,
function
(
e
)
{
e
.
preventDefault
();
e
.
preventDefault
();
...
@@ -39,7 +39,7 @@ $(function () {
...
@@ -39,7 +39,7 @@ $(function () {
test
(
"
should reset style to auto after finishing opening collapse
"
,
function
()
{
test
(
"
should reset style to auto after finishing opening collapse
"
,
function
()
{
$
.
support
.
transition
=
false
$
.
support
.
transition
=
false
stop
()
;
stop
()
$
(
'
<div class="collapse" style="height: 0px"/>
'
)
$
(
'
<div class="collapse" style="height: 0px"/>
'
)
.
bind
(
'
show
'
,
function
()
{
.
bind
(
'
show
'
,
function
()
{
ok
(
this
.
style
.
height
==
'
0px
'
)
ok
(
this
.
style
.
height
==
'
0px
'
)
...
@@ -51,4 +51,38 @@ $(function () {
...
@@ -51,4 +51,38 @@ $(function () {
.
collapse
(
'
show
'
)
.
collapse
(
'
show
'
)
})
})
test
(
"
should add active class to target when collapse shown
"
,
function
()
{
$
.
support
.
transition
=
false
stop
()
var
target
=
$
(
'
<a data-toggle="collapse" href="#test1"></a>
'
)
.
appendTo
(
$
(
'
#qunit-fixture
'
))
var
collapsible
=
$
(
'
<div id="test1"></div>
'
)
.
appendTo
(
$
(
'
#qunit-fixture
'
))
.
on
(
'
show
'
,
function
()
{
ok
(
!
target
.
hasClass
(
'
collapsed
'
))
start
()
})
target
.
click
()
})
test
(
"
should remove active class to target when collapse hidden
"
,
function
()
{
$
.
support
.
transition
=
false
stop
()
var
target
=
$
(
'
<a data-toggle="collapse" href="#test1"></a>
'
)
.
appendTo
(
$
(
'
#qunit-fixture
'
))
var
collapsible
=
$
(
'
<div id="test1" class="in"></div>
'
)
.
appendTo
(
$
(
'
#qunit-fixture
'
))
.
on
(
'
hide
'
,
function
()
{
ok
(
target
.
hasClass
(
'
collapsed
'
))
start
()
})
target
.
click
()
})
})
})
\ No newline at end of file
This diff is collapsed.
Click to expand it.
Write
Preview
Supports
Markdown
0%
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment