box-shadow mixin fix (#28004)

5dcf7cd3 · wojtask9 · XhmikosR · dc436427 · 5dcf7cd3
Commit 5dcf7cd3 authored 6 years ago by wojtask9 Committed by XhmikosR 6 years ago
Hide whitespace changes
Inline Side-by-side

Showing

with 9 additions and 3 deletions
+9 -3
--- a/scss/mixins/_box-shadow.scss
+++ b/scss/mixins/_box-shadow.scss
@@ -2,9 +2,15 @@
  @if $enable-shadows {
    $result: ();
-    @for $i from 1 through length($shadow) {
+    @if (length($shadow) == 1) {
-      @if nth($shadow, $i) != "none" {
+      // We can pass `@include box-shadow(none);`
-        $result: append($result, nth($shadow, $i), "comma");
+      $result: $shadow;
+    } @else {
+      // Filter to avoid invalid properties for example `box-shadow: none, 1px 1px black;`
+      @for $i from 1 through length($shadow) {
+        @if nth($shadow, $i) != "none" {
+          $result: append($result, nth($shadow, $i), "comma");
+        }
      }
    }
    @if (length($result) > 0) {