From 6bd5dc7d9fefd6d936def8a224bf38c6beeac234 Mon Sep 17 00:00:00 2001 From: Mark Otto <otto@github.com> Date: Thu, 20 Dec 2012 13:53:38 -0800 Subject: [PATCH] Add important flag to .show/.hide utility classes; remove .hide requirement from modals --- docs/assets/css/bootstrap.css | 5 +++-- docs/javascript.html | 8 ++++---- docs/templates/pages/javascript.mustache | 8 ++++---- less/modals.less | 1 + less/utilities.less | 4 ++-- 5 files changed, 14 insertions(+), 12 deletions(-) diff --git a/docs/assets/css/bootstrap.css b/docs/assets/css/bootstrap.css index 07f737734d..362ed3db40 100644 --- a/docs/assets/css/bootstrap.css +++ b/docs/assets/css/bootstrap.css @@ -4021,6 +4021,7 @@ fieldset[disabled] .navbar-inverse .btn-navbar { top: 10%; left: 50%; z-index: 1050; + display: none; width: 560px; margin-left: -280px; background-color: #fff; @@ -4911,11 +4912,11 @@ a.badge:hover { } .hide { - display: none; + display: none !important; } .show { - display: block; + display: block !important; } .invisible { diff --git a/docs/javascript.html b/docs/javascript.html index bc4d18ca7c..2d01af561f 100644 --- a/docs/javascript.html +++ b/docs/javascript.html @@ -186,7 +186,7 @@ $('#myModal').on('show', function (e) { <h3>Static example</h3> <p>A rendered modal with header, body, and set of actions in the footer.</p> <div class="bs-docs-example" style="background-color: #f5f5f5;"> - <div class="modal" style="position: relative; top: auto; left: auto; right: auto; margin: 0 auto 20px; z-index: 1; max-width: 100%;"> + <div class="modal" style="position: relative; top: auto; left: auto; right: auto; display: block; margin: 0 auto 20px; z-index: 1; max-width: 100%;"> <div class="modal-header"> <button type="button" class="close" data-dismiss="modal" aria-hidden="true">×</button> <h3>Modal header</h3> @@ -201,7 +201,7 @@ $('#myModal').on('show', function (e) { </div> </div> <pre class="prettyprint linenums"> -<div class="modal hide fade"> +<div class="modal fade"> <div class="modal-header"> <button type="button" class="close" data-dismiss="modal" aria-hidden="true">&times;</button> <h3>Modal header</h3> @@ -219,7 +219,7 @@ $('#myModal').on('show', function (e) { <h3>Live demo</h3> <p>Toggle a modal via JavaScript by clicking the button below. It will slide down and fade in from the top of the page.</p> <!-- sample modal content --> - <div id="myModal" class="modal hide fade" tabindex="-1" role="dialog" aria-labelledby="myModalLabel" aria-hidden="true"> + <div id="myModal" class="modal fade" tabindex="-1" role="dialog" aria-labelledby="myModalLabel" aria-hidden="true"> <div class="modal-header"> <button type="button" class="close" data-dismiss="modal" aria-hidden="true">×</button> <h3 id="myModalLabel">Modal Heading</h3> @@ -258,7 +258,7 @@ $('#myModal').on('show', function (e) { <a href="#myModal" role="button" class="btn" data-toggle="modal">Launch demo modal</a> <!-- Modal --> -<div id="myModal" class="modal hide fade" tabindex="-1" role="dialog" aria-labelledby="myModalLabel" aria-hidden="true"> +<div id="myModal" class="modal fade" tabindex="-1" role="dialog" aria-labelledby="myModalLabel" aria-hidden="true"> <div class="modal-header"> <button type="button" class="close" data-dismiss="modal" aria-hidden="true">×</button> <h3 id="myModalLabel">Modal header</h3> diff --git a/docs/templates/pages/javascript.mustache b/docs/templates/pages/javascript.mustache index b32514b28c..55a52e2589 100644 --- a/docs/templates/pages/javascript.mustache +++ b/docs/templates/pages/javascript.mustache @@ -119,7 +119,7 @@ $('#myModal').on('show', function (e) { <h3>Static example</h3> <p>A rendered modal with header, body, and set of actions in the footer.</p> <div class="bs-docs-example" style="background-color: #f5f5f5;"> - <div class="modal" style="position: relative; top: auto; left: auto; right: auto; margin: 0 auto 20px; z-index: 1; max-width: 100%;"> + <div class="modal" style="position: relative; top: auto; left: auto; right: auto; display: block; margin: 0 auto 20px; z-index: 1; max-width: 100%;"> <div class="modal-header"> <button type="button" class="close" data-dismiss="modal" aria-hidden="true">×</button> <h3>Modal header</h3> @@ -134,7 +134,7 @@ $('#myModal').on('show', function (e) { </div> </div>{{! /example }} <pre class="prettyprint linenums"> -<div class="modal hide fade"> +<div class="modal fade"> <div class="modal-header"> <button type="button" class="close" data-dismiss="modal" aria-hidden="true">&times;</button> <h3>Modal header</h3> @@ -152,7 +152,7 @@ $('#myModal').on('show', function (e) { <h3>Live demo</h3> <p>Toggle a modal via JavaScript by clicking the button below. It will slide down and fade in from the top of the page.</p> <!-- sample modal content --> - <div id="myModal" class="modal hide fade" tabindex="-1" role="dialog" aria-labelledby="myModalLabel" aria-hidden="true"> + <div id="myModal" class="modal fade" tabindex="-1" role="dialog" aria-labelledby="myModalLabel" aria-hidden="true"> <div class="modal-header"> <button type="button" class="close" data-dismiss="modal" aria-hidden="true">×</button> <h3 id="myModalLabel">Modal Heading</h3> @@ -191,7 +191,7 @@ $('#myModal').on('show', function (e) { <a href="#myModal" role="button" class="btn" data-toggle="modal">Launch demo modal</a> <!-- Modal --> -<div id="myModal" class="modal hide fade" tabindex="-1" role="dialog" aria-labelledby="myModalLabel" aria-hidden="true"> +<div id="myModal" class="modal fade" tabindex="-1" role="dialog" aria-labelledby="myModalLabel" aria-hidden="true"> <div class="modal-header"> <button type="button" class="close" data-dismiss="modal" aria-hidden="true">×</button> <h3 id="myModalLabel">Modal header</h3> diff --git a/less/modals.less b/less/modals.less index 8da32dea9f..7a233091df 100644 --- a/less/modals.less +++ b/less/modals.less @@ -26,6 +26,7 @@ top: 10%; left: 50%; z-index: @zindex-modal; + display: none; width: 560px; margin-left: -280px; background-color: #fff; diff --git a/less/utilities.less b/less/utilities.less index b11bcb3e27..d1e0a1beda 100644 --- a/less/utilities.less +++ b/less/utilities.less @@ -21,10 +21,10 @@ // ------------------------- .hide { - display: none; + display: none !important; } .show { - display: block; + display: block !important; } .invisible { visibility: hidden; -- GitLab