From a0936c326ff8b5cf7a31ff172f37c35b6828839b Mon Sep 17 00:00:00 2001 From: Mark Otto <markd.otto@gmail.com> Date: Wed, 17 Jan 2018 15:45:25 -0800 Subject: [PATCH] Outline button hover color (#25339) --- scss/_buttons.scss | 6 +----- scss/mixins/_buttons.scss | 4 ++-- 2 files changed, 3 insertions(+), 7 deletions(-) diff --git a/scss/_buttons.scss b/scss/_buttons.scss index 41b7068224..da6d87916d 100644 --- a/scss/_buttons.scss +++ b/scss/_buttons.scss @@ -68,11 +68,7 @@ fieldset:disabled a.btn { @each $color, $value in $theme-colors { .btn-outline-#{$color} { - @if $color == "light" { - @include button-outline-variant($value, $gray-900); - } @else { - @include button-outline-variant($value, $white); - } + @include button-outline-variant($value); } } diff --git a/scss/mixins/_buttons.scss b/scss/mixins/_buttons.scss index 1cbe671221..06ad6772fa 100644 --- a/scss/mixins/_buttons.scss +++ b/scss/mixins/_buttons.scss @@ -54,14 +54,14 @@ } } -@mixin button-outline-variant($color, $color-hover: #fff, $active-background: $color, $active-border: $color) { +@mixin button-outline-variant($color, $color-hover: color-yiq($color), $active-background: $color, $active-border: $color) { color: $color; background-color: transparent; background-image: none; border-color: $color; &:hover { - color: color-yiq($color); + color: $color-hover; background-color: $active-background; border-color: $active-border; } -- GitLab