Skip to content
GitLab
Explore
Projects
Groups
Snippets
Projects
Groups
Snippets
/
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
Menu
Open sidebar
Bootstrap
bootstrap
Commits
aba87279
Commit
aba87279
authored
7 years ago
by
XhmikosR
Browse files
Options
Download
Email Patches
Plain Diff
button without jquery
parent
47242cd0
main
cleanup-floating-forms
cssvar-function
dependabot/npm_and_yarn/stylelint-and-stylelint-config-twbs-bootstrap-15.3.0
extend-snippets
feat/data-target
floating-always-visible
floating-labels-icons
fod-main-banner
form-controls-with-icons
github/fork/719media/patch-13
github/fork/719media/patch-14
github/fork/719media/patch-9
github/fork/ChellyAhmed/fix-typo-reboot.md
github/fork/ChellyAhmed/offcanvas-scroll-back
github/fork/CtrlAltLilith/main
github/fork/Elysiome/offcanvas-optional-window-resizing
github/fork/JanSargsyan/main
github/fork/LunicLynx/support-different-line-height-for-buttons
github/fork/Psixodelik/main
github/fork/Ronid1/ronid1/offcanvas_static_backdrop
github/fork/RyanBerliner/tooltip-accessibility
github/fork/SantiagoPVazquez/Feature-default-border-bottom-to-dropdown-item
github/fork/Sir-Genius/utils
github/fork/Sumit-Singh-8/main
github/fork/Viktor-VERA2020/offcanvas-slide
github/fork/Zivangu9/input-group-for-form-control-plaintext
github/fork/alpadev/alpadev/call-dispose-on-component-reinstantiation
github/fork/astagi/fix/tree-shake-modules
github/fork/compnerd/dark-accordion-icon
github/fork/derSascha/dropdown-dont-close-on-input-click
github/fork/dev-ph1l/main
github/fork/donquixote/issue-33861-utl-mixin
github/fork/florianlacreuse/mixin-make-row-gutter-y
github/fork/gregorw/main
github/fork/iteggmbh/transitionend-dispose-race
github/fork/jdelStrother/patch-1
github/fork/jonnysp/form-floating
github/fork/jonnysp/independent-offcanvas
github/fork/jonnysp/theme-dark-on-card-and-modal-fix
github/fork/josefdlange/floating-label-placeholder-opacity
github/fork/julien-deramond/enhance-change-version.js
github/fork/julien-deramond/main-jd-fix-offset-content
github/fork/julien-deramond/main-jd-issue-with-utitlies
github/fork/julien-deramond/main-xmr-pa11y-ci-jd-add-hideElements
github/fork/kyletsang/fix-tooltip-padding
github/fork/lacutah/CheckboxCenteringDocumentation
github/fork/lekoala/patch-3
github/fork/louismaximepiton/main-kld-lmp-collapse-proposal
github/fork/louismaximepiton/main-lmp-card-inner-border-radius-fix
github/fork/louismaximepiton/main-lmp-carousel-multiple-images
github/fork/louismaximepiton/main-lmp-css-var-init
github/fork/louismaximepiton/main-lmp-disabled-floating-label-fix
github/fork/louismaximepiton/main-lmp-input-range-fix
github/fork/louismaximepiton/main-lmp-shift-color
github/fork/louismaximepiton/main-lmp-table-active-tr-fix
github/fork/maciek-szn/switch
github/fork/michael-roth/feature/19964-multiple-tab-targets
github/fork/mistic100/dom-utils
github/fork/nkdas91/accordion
github/fork/nstungcom/fix-missing-modal-open-class
github/fork/oraliahdz/animation-utilities
github/fork/pine3ree/patch-7
github/fork/pouwerkerk/unindent-scss-docs-shortcode
github/fork/smares/smares-no-scolling-on-modal-close
github/fork/tgm-git/patch-1
gs-forms
gs-toasts-with-animated-progress-bar
gs/add-history-helper
gs/change-version-dir-on-docs
gs/data-must-set-onlu-one-instance
gs/docs/fix-drop-down-error
gs/event-handler-2
gs/make-docs-js-build
gs/make-simple-attribute-toggler
gs/popover-fix-doc
gs/provide-steConfig-method
gs/scrollspy-smoothscroll-option-use-browser-history
gs/streamline-jqueryInterface
gs/support-drop-down-in-navbar
gs/test-js-generic-trigger
gs/try-web-components
gs/tweak-collapse-js-selector
gs/use-event-handler-in-cocmponent
gs/use-rollup-replace-for-version
jo-docs-thanks-page
jo-ssr-friendly
logical-props-spacing-utils
main-fod-disabled-form-check-label
main-fod-nested-accordion
main-fod-simpler-table-structure
main-fod-table-separator
main-fod-utilities-contrast
main-jd-abbr-title
main-jd-add-chips
main-jd-add-doc-for-sass-custom-colors
main-jd-add-enable-host-to-handle-web-components
main-jd-browserstack-fine-tune
main-jd-browserstack-updates
main-jd-docs-consistent-usage-of-css-sections-step-2
main-jd-fix-docs-headers-in-white
main-jd-fix-highlight-docs-border-radius
main-jd-fix-placeholder-color-background-params-for-img-markup
main-jd-glossary-experiment
main-jd-postcss-drop-empty-css-vars
main-jd-proto-doc-astro
main-jd-skip-navigation-component
main-jd-stackblitz-for-examples
main-jd-upgrade-browserlistrc
main-jd-use-host
main-lmp-dark-theme-customization
main-lmp-handle-scroll-target
main-lmp-tab-fix
main-mc-opensearch
main-xmr-bundlewatch-action
main-xmr-eslint-plugin-compat
main-xmr-hugo-docs-vendor
main-xmr-hugo-rm-ver
main-xmr-linkinator-prod
main-xmr-min-mangle
main-xmr-pa11y-ci
more-darkmode-examples
nested-dropdowns
patrickhlauke-issue37428
patrickhlauke-use-of-color-tweaks
pr/34102
pr/37590
previous-next-docs-links
sticky-thead
utilities-functions-mixin
v530-dev
v6-postcss-custom-media
v6-spinner-dots
v6/gs/use-floating-ui-in-place-of-popper
xmr/dev
xmr/docs-png
xmr/docs-svgs
xmr/hugo-reorg-files
xmr/js-2
xmr/markdownlint
xmr/prepare-530-alpha2
xmr/xo
v5.3.0-alpha1
v5.2.3
v5.2.2
v5.2.1
v5.2.0
v5.2.0-beta1
v5.1.3
v5.1.2
v5.1.1
v5.1.0
v5.0.2
v5.0.1
v5.0.0
v5.0.0-beta3
v5.0.0-beta2
v5.0.0-beta1
v5.0.0-alpha3
v5.0.0-alpha2
v5.0.0-alpha1
5 merge requests
!31948
Examples/Floating-labels: fix bad behavior with autofill
,
!30064
test
,
!29779
Responsive sizing
,
!28882
fix custom-select-indicator in IE10
,
!28721
Hot test
Changes
4
Hide whitespace changes
Inline
Side-by-side
Showing
4 changed files
js/src/button.js
+50
-32
js/src/button.js
js/src/util.js
+2
-2
js/src/util.js
js/tests/unit/button.js
+18
-13
js/tests/unit/button.js
js/tests/visual/button.html
+2
-0
js/tests/visual/button.html
with
72 additions
and
47 deletions
+72
-47
js/src/button.js
+
50
-
32
View file @
aba87279
...
@@ -5,7 +5,9 @@
...
@@ -5,7 +5,9 @@
* --------------------------------------------------------------------------
* --------------------------------------------------------------------------
*/
*/
import
$
from
'
jquery
'
import
Data
from
'
./dom/data
'
import
EventHandler
from
'
./dom/eventHandler
'
import
SelectorEngine
from
'
./dom/selectorEngine
'
/**
/**
* ------------------------------------------------------------------------
* ------------------------------------------------------------------------
...
@@ -18,7 +20,6 @@ const VERSION = '4.3.1'
...
@@ -18,7 +20,6 @@ const VERSION = '4.3.1'
const
DATA_KEY
=
'
bs.button
'
const
DATA_KEY
=
'
bs.button
'
const
EVENT_KEY
=
`.
${
DATA_KEY
}
`
const
EVENT_KEY
=
`.
${
DATA_KEY
}
`
const
DATA_API_KEY
=
'
.data-api
'
const
DATA_API_KEY
=
'
.data-api
'
const
JQUERY_NO_CONFLICT
=
$
.
fn
[
NAME
]
const
ClassName
=
{
const
ClassName
=
{
ACTIVE
:
'
active
'
,
ACTIVE
:
'
active
'
,
...
@@ -36,8 +37,8 @@ const Selector = {
...
@@ -36,8 +37,8 @@ const Selector = {
const
Event
=
{
const
Event
=
{
CLICK_DATA_API
:
`click
${
EVENT_KEY
}${
DATA_API_KEY
}
`
,
CLICK_DATA_API
:
`click
${
EVENT_KEY
}${
DATA_API_KEY
}
`
,
FOCUS_
BLUR_
DATA_API
:
`focus
${
EVENT_KEY
}${
DATA_API_KEY
}
`
+
FOCUS_DATA_API
:
`focus
${
EVENT_KEY
}${
DATA_API_KEY
}
`
,
`blur
${
EVENT_KEY
}${
DATA_API_KEY
}
`
BLUR_DATA_API
:
`blur
${
EVENT_KEY
}${
DATA_API_KEY
}
`
}
}
/**
/**
...
@@ -62,12 +63,14 @@ class Button {
...
@@ -62,12 +63,14 @@ class Button {
toggle
()
{
toggle
()
{
let
triggerChangeEvent
=
true
let
triggerChangeEvent
=
true
let
addAriaPressed
=
true
let
addAriaPressed
=
true
const
rootElement
=
$
(
this
.
_element
).
closest
(
const
rootElement
=
SelectorEngine
.
closest
(
this
.
_element
,
Selector
.
DATA_TOGGLE
Selector
.
DATA_TOGGLE
)
[
0
]
)
if
(
rootElement
)
{
if
(
rootElement
)
{
const
input
=
this
.
_element
.
querySelector
(
Selector
.
INPUT
)
const
input
=
SelectorEngine
.
findOne
(
Selector
.
INPUT
,
this
.
_element
)
if
(
input
)
{
if
(
input
)
{
if
(
input
.
type
===
'
radio
'
)
{
if
(
input
.
type
===
'
radio
'
)
{
...
@@ -75,10 +78,10 @@ class Button {
...
@@ -75,10 +78,10 @@ class Button {
this
.
_element
.
classList
.
contains
(
ClassName
.
ACTIVE
))
{
this
.
_element
.
classList
.
contains
(
ClassName
.
ACTIVE
))
{
triggerChangeEvent
=
false
triggerChangeEvent
=
false
}
else
{
}
else
{
const
activeElement
=
rootElement
.
querySelector
(
Selector
.
ACTIVE
)
const
activeElement
=
SelectorEngine
.
findOne
(
Selector
.
ACTIVE
,
rootElement
)
if
(
activeElement
)
{
if
(
activeElement
)
{
$
(
activeElement
)
.
remove
Class
(
ClassName
.
ACTIVE
)
activeElement
.
classList
.
remove
(
ClassName
.
ACTIVE
)
}
}
}
}
}
}
...
@@ -91,7 +94,7 @@ class Button {
...
@@ -91,7 +94,7 @@ class Button {
return
return
}
}
input
.
checked
=
!
this
.
_element
.
classList
.
contains
(
ClassName
.
ACTIVE
)
input
.
checked
=
!
this
.
_element
.
classList
.
contains
(
ClassName
.
ACTIVE
)
$
(
input
)
.
trigger
(
'
change
'
)
EventHandler
.
trigger
(
input
,
'
change
'
)
}
}
input
.
focus
()
input
.
focus
()
...
@@ -105,12 +108,12 @@ class Button {
...
@@ -105,12 +108,12 @@ class Button {
}
}
if
(
triggerChangeEvent
)
{
if
(
triggerChangeEvent
)
{
$
(
this
.
_element
)
.
toggle
Class
(
ClassName
.
ACTIVE
)
this
.
_element
.
classList
.
toggle
(
ClassName
.
ACTIVE
)
}
}
}
}
dispose
()
{
dispose
()
{
$
.
removeData
(
this
.
_element
,
DATA_KEY
)
Data
.
removeData
(
this
.
_element
,
DATA_KEY
)
this
.
_element
=
null
this
.
_element
=
null
}
}
...
@@ -118,11 +121,11 @@ class Button {
...
@@ -118,11 +121,11 @@ class Button {
static
_jQueryInterface
(
config
)
{
static
_jQueryInterface
(
config
)
{
return
this
.
each
(
function
()
{
return
this
.
each
(
function
()
{
let
data
=
$
(
this
).
data
(
DATA_KEY
)
let
data
=
Data
.
getData
(
this
,
DATA_KEY
)
if
(
!
data
)
{
if
(
!
data
)
{
data
=
new
Button
(
this
)
data
=
new
Button
(
this
)
$
(
this
).
data
(
DATA_KEY
,
data
)
Data
.
setData
(
this
,
DATA_KEY
,
data
)
}
}
if
(
config
===
'
toggle
'
)
{
if
(
config
===
'
toggle
'
)
{
...
@@ -138,34 +141,49 @@ class Button {
...
@@ -138,34 +141,49 @@ class Button {
* ------------------------------------------------------------------------
* ------------------------------------------------------------------------
*/
*/
$
(
document
)
EventHandler
.
on
(
document
,
Event
.
CLICK_DATA_API
,
Selector
.
DATA_TOGGLE_CARROT
,
(
event
)
=>
{
.
on
(
Event
.
CLICK_DATA_API
,
Selector
.
DATA_TOGGLE_CARROT
,
(
event
)
=>
{
event
.
preventDefault
()
event
.
preventDefault
()
let
button
=
event
.
target
let
button
=
event
.
target
if
(
!
button
.
classList
.
contains
(
ClassName
.
BUTTON
))
{
button
=
SelectorEngine
.
closest
(
button
,
Selector
.
BUTTON
)
}
if
(
!
$
(
button
).
hasClass
(
ClassName
.
BUTTON
))
{
let
data
=
Data
.
getData
(
button
,
DATA_KEY
)
button
=
$
(
button
).
closest
(
Selector
.
BUTTON
)
if
(
!
data
)
{
}
data
=
new
Button
(
button
)
Data
.
setData
(
button
,
DATA_KEY
,
data
)
}
data
.
toggle
()
})
Button
.
_jQueryInterface
.
call
(
$
(
button
),
'
toggle
'
)
EventHandler
.
on
(
document
,
Event
.
FOCUS_DATA_API
,
Selector
.
DATA_TOGGLE_CARROT
,
(
event
)
=>
{
})
const
button
=
SelectorEngine
.
closest
(
event
.
target
,
Selector
.
BUTTON
)
.
on
(
Event
.
FOCUS_BLUR_DATA_API
,
Selector
.
DATA_TOGGLE_CARROT
,
(
event
)
=>
{
button
.
classList
.
add
(
ClassName
.
FOCUS
)
const
button
=
$
(
event
.
target
).
closest
(
Selector
.
BUTTON
)[
0
]
})
$
(
button
).
toggleClass
(
ClassName
.
FOCUS
,
/^focus
(
in
)?
$/
.
test
(
event
.
type
))
})
EventHandler
.
on
(
document
,
Event
.
BLUR_DATA_API
,
Selector
.
DATA_TOGGLE_CARROT
,
(
event
)
=>
{
const
button
=
SelectorEngine
.
closest
(
event
.
target
,
Selector
.
BUTTON
)
button
.
classList
.
remove
(
ClassName
.
FOCUS
)
})
/**
/**
* ------------------------------------------------------------------------
* ------------------------------------------------------------------------
* jQuery
* jQuery
* ------------------------------------------------------------------------
* ------------------------------------------------------------------------
* add .button to jQuery only if jQuery is present
*/
*/
$
.
fn
[
NAME
]
=
Button
.
_jQueryInterface
if
(
typeof
window
.
$
!==
'
undefined
'
||
typeof
window
.
jQuery
!==
'
undefined
'
)
{
$
.
fn
[
NAME
].
Constructor
=
Button
const
$
=
window
.
$
||
window
.
jQuery
$
.
fn
[
NAME
].
noConflict
=
()
=>
{
const
JQUERY_NO_CONFLICT
=
$
.
fn
[
NAME
]
$
.
fn
[
NAME
]
=
JQUERY_NO_CONFLICT
$
.
fn
[
NAME
]
=
Button
.
_jQueryInterface
return
Button
.
_jQueryInterface
$
.
fn
[
NAME
].
Constructor
=
Button
$
.
fn
[
NAME
].
noConflict
=
()
=>
{
$
.
fn
[
NAME
]
=
JQUERY_NO_CONFLICT
return
Button
.
_jQueryInterface
}
}
}
export
default
Button
export
default
Button
This diff is collapsed.
Click to expand it.
js/src/util.js
+
2
-
2
View file @
aba87279
...
@@ -55,8 +55,8 @@ const Util = {
...
@@ -55,8 +55,8 @@ const Util = {
}
}
// Get transition-duration of the element
// Get transition-duration of the element
let
transitionDuration
=
$
(
element
).
css
(
'
transition
-d
uration
'
)
let
transitionDuration
=
element
.
style
.
transition
D
uration
let
transitionDelay
=
$
(
element
).
css
(
'
transition
-d
elay
'
)
let
transitionDelay
=
element
.
style
.
transition
D
elay
const
floatTransitionDuration
=
parseFloat
(
transitionDuration
)
const
floatTransitionDuration
=
parseFloat
(
transitionDuration
)
const
floatTransitionDelay
=
parseFloat
(
transitionDelay
)
const
floatTransitionDelay
=
parseFloat
(
transitionDelay
)
...
...
This diff is collapsed.
Click to expand it.
js/tests/unit/button.js
+
18
-
13
View file @
aba87279
...
@@ -106,17 +106,19 @@ $(function () {
...
@@ -106,17 +106,19 @@ $(function () {
QUnit
.
test
(
'
should check for closest matching toggle
'
,
function
(
assert
)
{
QUnit
.
test
(
'
should check for closest matching toggle
'
,
function
(
assert
)
{
assert
.
expect
(
12
)
assert
.
expect
(
12
)
var
groupHTML
=
'
<div class="btn-group" data-toggle="buttons">
'
+
var
groupHTML
=
'
<label class="btn btn-primary active">
'
+
'
<div class="btn-group" data-toggle="buttons">
'
'
<input type="radio" name="options" id="option1" checked="true"> Option 1
'
+
+
'
<label class="btn btn-primary active">
'
'
</label>
'
+
+
'
<input type="radio" name="options" id="option1" checked="true"> Option 1
'
'
<label class="btn btn-primary">
'
+
+
'
</label>
'
'
<input type="radio" name="options" id="option2"> Option 2
'
+
+
'
<label class="btn btn-primary">
'
'
</label>
'
+
+
'
<input type="radio" name="options" id="option2"> Option 2
'
'
<label class="btn btn-primary">
'
+
+
'
</label>
'
'
<input type="radio" name="options" id="option3"> Option 3
'
+
+
'
<label class="btn btn-primary">
'
'
</label>
'
+
+
'
<input type="radio" name="options" id="option3"> Option 3
'
'
</div>
'
+
'
</label>
'
+
'
</div>
'
var
$group
=
$
(
groupHTML
).
appendTo
(
'
#qunit-fixture
'
)
var
$group
=
$
(
groupHTML
).
appendTo
(
'
#qunit-fixture
'
)
var
$btn1
=
$group
.
children
().
eq
(
0
)
var
$btn1
=
$group
.
children
().
eq
(
0
)
...
@@ -126,13 +128,16 @@ $(function () {
...
@@ -126,13 +128,16 @@ $(function () {
assert
.
ok
(
$btn1
.
find
(
'
input
'
).
prop
(
'
checked
'
),
'
btn1 is checked
'
)
assert
.
ok
(
$btn1
.
find
(
'
input
'
).
prop
(
'
checked
'
),
'
btn1 is checked
'
)
assert
.
ok
(
!
$btn2
.
hasClass
(
'
active
'
),
'
btn2 does not have active class
'
)
assert
.
ok
(
!
$btn2
.
hasClass
(
'
active
'
),
'
btn2 does not have active class
'
)
assert
.
ok
(
!
$btn2
.
find
(
'
input
'
).
prop
(
'
checked
'
),
'
btn2 is not checked
'
)
assert
.
ok
(
!
$btn2
.
find
(
'
input
'
).
prop
(
'
checked
'
),
'
btn2 is not checked
'
)
$btn2
.
find
(
'
input
'
).
trigger
(
'
click
'
)
EventHandler
.
trigger
(
$btn2
.
find
(
'
input
'
)[
0
],
'
click
'
)
assert
.
ok
(
!
$btn1
.
hasClass
(
'
active
'
),
'
btn1 does not have active class
'
)
assert
.
ok
(
!
$btn1
.
hasClass
(
'
active
'
),
'
btn1 does not have active class
'
)
assert
.
ok
(
!
$btn1
.
find
(
'
input
'
).
prop
(
'
checked
'
),
'
btn1 is not checked
'
)
assert
.
ok
(
!
$btn1
.
find
(
'
input
'
).
prop
(
'
checked
'
),
'
btn1 is not checked
'
)
assert
.
ok
(
$btn2
.
hasClass
(
'
active
'
),
'
btn2 has active class
'
)
assert
.
ok
(
$btn2
.
hasClass
(
'
active
'
),
'
btn2 has active class
'
)
assert
.
ok
(
$btn2
.
find
(
'
input
'
).
prop
(
'
checked
'
),
'
btn2 is checked
'
)
assert
.
ok
(
$btn2
.
find
(
'
input
'
).
prop
(
'
checked
'
),
'
btn2 is checked
'
)
$btn2
.
find
(
'
input
'
).
trigger
(
'
click
'
)
// Clicking an already checked radio should not un-check it
EventHandler
.
trigger
(
$btn2
.
find
(
'
input
'
)[
0
],
'
click
'
)
// clicking an already checked radio should not un-check it
assert
.
ok
(
!
$btn1
.
hasClass
(
'
active
'
),
'
btn1 does not have active class
'
)
assert
.
ok
(
!
$btn1
.
hasClass
(
'
active
'
),
'
btn1 does not have active class
'
)
assert
.
ok
(
!
$btn1
.
find
(
'
input
'
).
prop
(
'
checked
'
),
'
btn1 is not checked
'
)
assert
.
ok
(
!
$btn1
.
find
(
'
input
'
).
prop
(
'
checked
'
),
'
btn1 is not checked
'
)
assert
.
ok
(
$btn2
.
hasClass
(
'
active
'
),
'
btn2 has active class
'
)
assert
.
ok
(
$btn2
.
hasClass
(
'
active
'
),
'
btn2 has active class
'
)
...
...
This diff is collapsed.
Click to expand it.
js/tests/visual/button.html
+
2
-
0
View file @
aba87279
...
@@ -46,6 +46,8 @@
...
@@ -46,6 +46,8 @@
<script
src=
"../../../node_modules/jquery/dist/jquery.slim.min.js"
></script>
<script
src=
"../../../node_modules/jquery/dist/jquery.slim.min.js"
></script>
<script
src=
"../../dist/dom/eventHandler.js"
></script>
<script
src=
"../../dist/dom/eventHandler.js"
></script>
<script
src=
"../../dist/dom/selectorEngine.js"
></script>
<script
src=
"../../dist/dom/data.js"
></script>
<script
src=
"../../dist/util.js"
></script>
<script
src=
"../../dist/util.js"
></script>
<script
src=
"../../dist/button.js"
></script>
<script
src=
"../../dist/button.js"
></script>
</body>
</body>
...
...
This diff is collapsed.
Click to expand it.
Write
Preview
Supports
Markdown
0%
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment
Menu
Explore
Projects
Groups
Snippets