Skip to content
GitLab
Projects
Groups
Snippets
/
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
Menu
Open sidebar
Bootstrap
bootstrap
Commits
be1232c5
Commit
be1232c5
authored
9 years ago
by
Chris Rebert
Browse files
Options
Download
Email Patches
Plain Diff
Add comments explaining why we don't make `<img>`s responsive by default
Refs
#18178
[ci skip]
parent
4d17a04a
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
scss/_images.scss
+6
-0
scss/_images.scss
scss/_reboot.scss
+2
-0
scss/_reboot.scss
with
8 additions
and
0 deletions
+8
-0
scss/_images.scss
+
6
-
0
View file @
be1232c5
// Responsive images (ensure images don't scale beyond their parents)
//
// This is purposefully opt-in via an explicit class rather than being the default for all `<img>`s.
// We previously tried the "images are responsive by default" approach in Bootstrap v2,
// and abandoned it in Bootstrap v3 because it breaks lots of third-party widgets (including Google Maps)
// which weren't expecting the images within themselves to be involuntarily resized.
// See also https://github.com/twbs/bootstrap/issues/18178
.img-fluid
{
@include
img-fluid
();
}
...
...
This diff is collapsed.
Click to expand it.
scss/_reboot.scss
+
2
-
0
View file @
be1232c5
...
...
@@ -191,6 +191,8 @@ img {
// By default, `<img>`s are `inline-block`. This assumes that, and vertically
// centers them. This won't apply should you reset them to `block` level.
vertical-align
:
middle
;
// Note: `<img>`s are deliberately not made responsive by default.
// For the rationale behind this, see the comments on the `.img-fluid` class.
}
...
...
This diff is collapsed.
Click to expand it.
Write
Preview
Supports
Markdown
0%
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment