Skip to content
GitLab
Explore
Projects
Groups
Snippets
Projects
Groups
Snippets
/
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
Menu
Open sidebar
Bootstrap
bootstrap
Commits
db9e8ee8
Commit
db9e8ee8
authored
10 years ago
by
saranya.r
Committed by
Heinrich Fenkart
10 years ago
Browse files
Options
Download
Email Patches
Plain Diff
Fix tooltip misplacement with "auto top"
Fixes
#14322
. Closes #14581.
parent
c5c67d0f
4 merge requests
!28721
Hot test
,
!16605
Test pull please ignore
,
!22103
test
,
!25326
Adjust examples
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
js/tests/unit/tooltip.js
+50
-0
js/tests/unit/tooltip.js
js/tooltip.js
+1
-1
js/tooltip.js
with
51 additions
and
1 deletion
+51
-1
js/tests/unit/tooltip.js
+
50
-
0
View file @
db9e8ee8
...
...
@@ -382,6 +382,56 @@ $(function () {
$style
.
remove
()
})
test
(
'
should position tip on top if viewport has enough space and placement is "auto top"
'
,
function
()
{
var
styles
=
'
<style>
'
+
'
body { padding-top: 100px; }
'
+
'
section { height: 300px; border: 1px solid red; padding-top: 50px }
'
+
'
div[rel="tooltip"] { width: 150px; border: 1px solid blue; }
'
+
'
</style>
'
var
$styles
=
$
(
styles
).
appendTo
(
'
head
'
)
var
$container
=
$
(
'
<section/>
'
).
appendTo
(
'
#qunit-fixture
'
)
var
$target
=
$
(
'
<div rel="tooltip" title="tip"/>
'
)
.
appendTo
(
$container
)
.
bootstrapTooltip
({
placement
:
'
auto top
'
,
viewport
:
'
section
'
})
$target
.
bootstrapTooltip
(
'
show
'
)
ok
(
$
(
'
.tooltip
'
).
is
(
'
.top
'
),
'
top positioned tooltip is dynamically positioned to top
'
)
$target
.
bootstrapTooltip
(
'
hide
'
)
equal
(
$
(
'
.tooltip
'
).
length
,
0
,
'
tooltip removed from dom
'
)
$styles
.
remove
()
})
test
(
'
should position tip on bottom if the tip
\'
s dimension exceeds the viewport area and placement is "auto top"
'
,
function
()
{
var
styles
=
'
<style>
'
+
'
body { padding-top: 100px; }
'
+
'
section { height: 300px; border: 1px solid red; }
'
+
'
div[rel="tooltip"] { width: 150px; border: 1px solid blue; }
'
+
'
</style>
'
var
$styles
=
$
(
styles
).
appendTo
(
'
head
'
)
var
$container
=
$
(
'
<section/>
'
).
appendTo
(
'
#qunit-fixture
'
)
var
$target
=
$
(
'
<div rel="tooltip" title="tip"/>
'
)
.
appendTo
(
$container
)
.
bootstrapTooltip
({
placement
:
'
auto top
'
,
viewport
:
'
section
'
})
$target
.
bootstrapTooltip
(
'
show
'
)
ok
(
$
(
'
.tooltip
'
).
is
(
'
.bottom
'
),
'
top positioned tooltip is dynamically positioned to bottom
'
)
$target
.
bootstrapTooltip
(
'
hide
'
)
equal
(
$
(
'
.tooltip
'
).
length
,
0
,
'
tooltip removed from dom
'
)
$styles
.
remove
()
})
test
(
'
should adjust the tip
\'
s top position when up against the top of the viewport
'
,
function
()
{
var
styles
=
'
<style>
'
+
'
.tooltip .tooltip-inner { width: 200px; height: 200px; max-width: none; }
'
...
...
This diff is collapsed.
Click to expand it.
js/tooltip.js
+
1
-
1
View file @
db9e8ee8
...
...
@@ -192,7 +192,7 @@
var
parentDim
=
this
.
getPosition
(
$parent
)
placement
=
placement
==
'
bottom
'
&&
pos
.
top
+
pos
.
height
+
actualHeight
-
parentDim
.
scroll
>
parentDim
.
height
?
'
top
'
:
placement
==
'
top
'
&&
pos
.
top
-
parentDim
.
scroll
-
actualHeight
<
0
?
'
bottom
'
:
placement
==
'
top
'
&&
pos
.
top
-
parentDim
.
scroll
-
actualHeight
<
parentDim
.
top
?
'
bottom
'
:
placement
==
'
right
'
&&
pos
.
right
+
actualWidth
>
parentDim
.
width
?
'
left
'
:
placement
==
'
left
'
&&
pos
.
left
-
actualWidth
<
parentDim
.
left
?
'
right
'
:
placement
...
...
This diff is collapsed.
Click to expand it.
Write
Preview
Supports
Markdown
0%
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment
Menu
Explore
Projects
Groups
Snippets