From e23868c9cf395eabc4a8c6f00a8b58df13aacac7 Mon Sep 17 00:00:00 2001 From: "Patrick H. Lauke" <redux@splintered.co.uk> Date: Thu, 11 Jun 2015 12:40:24 +0100 Subject: [PATCH] Add role="document" to modal itself Initial fix to generalise use of modals. Generally, true role="dialog" containers would require only forms/controls as content, with all other text correctly and explicitly associated via aria-labelledby/aria-describedby and similar...but as authors use modals also as generic overlays, this extra role is required to get AT (particularly NVDA) out of "forms" mode and reenable reading keys --- docs/_includes/js/modal.html | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/docs/_includes/js/modal.html b/docs/_includes/js/modal.html index 840091f854..0c2f64f862 100644 --- a/docs/_includes/js/modal.html +++ b/docs/_includes/js/modal.html @@ -69,7 +69,7 @@ $('#myModal').on('shown.bs.modal', function () { <p>Toggle a modal via JavaScript by clicking the button below. It will slide down and fade in from the top of the page.</p> <!-- sample modal content --> <div id="myModal" class="modal fade" tabindex="-1" role="dialog" aria-labelledby="myModalLabel"> - <div class="modal-dialog"> + <div class="modal-dialog" role="document"> <div class="modal-content"> <div class="modal-header"> @@ -121,7 +121,7 @@ $('#myModal').on('shown.bs.modal', function () { <!-- Modal --> <div class="modal fade" id="myModal" tabindex="-1" role="dialog" aria-labelledby="myModalLabel"> - <div class="modal-dialog"> + <div class="modal-dialog" role="document"> <div class="modal-content"> <div class="modal-header"> <button type="button" class="close" data-dismiss="modal" aria-label="Close"><span aria-hidden="true">×</span></button> @@ -222,7 +222,7 @@ $('#myModal').on('shown.bs.modal', function () { <p>To take advantage of the Bootstrap grid system within a modal, just nest <code>.container-fluid</code> within the <code>.modal-body</code> and then use the normal grid system classes within this container.</p> <!-- sample modal content --> <div id="gridSystemModal" class="modal fade" tabindex="-1" role="dialog" aria-labelledby="gridModalLabel"> - <div class="modal-dialog"> + <div class="modal-dialog" role="document"> <div class="modal-content"> <div class="modal-header"> <button type="button" class="close" data-dismiss="modal" aria-label="Close"><span aria-hidden="true">×</span></button> @@ -270,7 +270,7 @@ $('#myModal').on('shown.bs.modal', function () { </div><!-- /example --> {% highlight html %} <div class="modal fade" role="dialog" aria-labelledby="gridSystemModalLabel"> - <div class="modal-dialog"> + <div class="modal-dialog" role="document"> <div class="modal-content"> <div class="modal-header"> <button type="button" class="close" data-dismiss="modal" aria-label="Close"><span aria-hidden="true">×</span></button> @@ -323,7 +323,7 @@ $('#myModal').on('shown.bs.modal', function () { ...more buttons... <div class="modal fade" id="exampleModal" tabindex="-1" role="dialog" aria-labelledby="exampleModalLabel"> - <div class="modal-dialog"> + <div class="modal-dialog" role="document"> <div class="modal-content"> <div class="modal-header"> <button type="button" class="close" data-dismiss="modal" aria-label="Close"><span aria-hidden="true">×</span></button> @@ -356,7 +356,7 @@ $('#myModal').on('shown.bs.modal', function () { ...more buttons... <div class="modal fade" id="exampleModal" tabindex="-1" role="dialog" aria-labelledby="exampleModalLabel"> - <div class="modal-dialog"> + <div class="modal-dialog" role="document"> <div class="modal-content"> <div class="modal-header"> <button type="button" class="close" data-dismiss="modal" aria-label="Close"><span aria-hidden="true">×</span></button> -- GitLab