diff --git a/js/src/button.js b/js/src/button.js index 75b21d94d18a3c6f5231e928e08f844cbe6623cd..53ae16955ca564531f27b708c28c397870673f8e 100644 --- a/js/src/button.js +++ b/js/src/button.js @@ -29,7 +29,7 @@ const ClassName = { const Selector = { DATA_TOGGLE_CARROT : '[data-toggle^="button"]', DATA_TOGGLE : '[data-toggle="buttons"]', - INPUT : 'input', + INPUT : 'input:not([type="hidden"])', ACTIVE : '.active', BUTTON : '.btn' } diff --git a/js/tests/unit/button.js b/js/tests/unit/button.js index 9576dd256f22bb19b3e61d7ab8e04e10be6a5779..724545a532e67913f24d4d6755bdf107a7510bb3 100644 --- a/js/tests/unit/button.js +++ b/js/tests/unit/button.js @@ -139,6 +139,29 @@ $(function () { assert.ok($btn2.find('input').prop('checked'), 'btn2 is checked') }) + QUnit.test('should only toggle selectable inputs', function (assert) { + assert.expect(6) + var groupHTML = '<div class="btn-group" data-toggle="buttons">' + + '<label class="btn btn-primary active">' + + '<input type="hidden" name="option1" id="option1-default" value="false">' + + '<input type="checkbox" name="option1" id="option1" checked="true"> Option 1' + + '</label>' + + '</div>' + var $group = $(groupHTML).appendTo('#qunit-fixture') + + var $btn = $group.children().eq(0) + var $hidden = $btn.find('input#option1-default') + var $cb = $btn.find('input#option1') + + assert.ok($btn.hasClass('active'), 'btn has active class') + assert.ok($cb.prop('checked'), 'btn is checked') + assert.ok(!$hidden.prop('checked'), 'hidden is not checked') + $btn.trigger('click') + assert.ok(!$btn.hasClass('active'), 'btn does not have active class') + assert.ok(!$cb.prop('checked'), 'btn is not checked') + assert.ok(!$hidden.prop('checked'), 'hidden is not checked') // should not be changed + }) + QUnit.test('should not add aria-pressed on labels for radio/checkbox inputs in a data-toggle="buttons" group', function (assert) { assert.expect(2) var groupHTML = '<div class="btn-group" data-toggle="buttons">' +