Skip to content
GitLab
Explore
Projects
Groups
Snippets
Projects
Groups
Snippets
/
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
Menu
Open sidebar
Bootstrap
bootstrap
Commits
fee11fd7
Commit
fee11fd7
authored
6 years ago
by
Johann-S
Committed by
XhmikosR
6 years ago
Browse files
Options
Download
Email Patches
Plain Diff
use our selector engine instead of native api
parent
58773061
main
cleanup-floating-forms
cssvar-function
dependabot/npm_and_yarn/stylelint-and-stylelint-config-twbs-bootstrap-15.3.0
extend-snippets
feat/data-target
floating-always-visible
floating-labels-icons
fod-main-banner
form-controls-with-icons
github/fork/719media/patch-13
github/fork/719media/patch-14
github/fork/719media/patch-9
github/fork/ChellyAhmed/fix-typo-reboot.md
github/fork/ChellyAhmed/offcanvas-scroll-back
github/fork/CtrlAltLilith/main
github/fork/Elysiome/offcanvas-optional-window-resizing
github/fork/JanSargsyan/main
github/fork/LunicLynx/support-different-line-height-for-buttons
github/fork/Psixodelik/main
github/fork/Ronid1/ronid1/offcanvas_static_backdrop
github/fork/RyanBerliner/tooltip-accessibility
github/fork/SantiagoPVazquez/Feature-default-border-bottom-to-dropdown-item
github/fork/Sir-Genius/utils
github/fork/Sumit-Singh-8/main
github/fork/Viktor-VERA2020/offcanvas-slide
github/fork/Zivangu9/input-group-for-form-control-plaintext
github/fork/alpadev/alpadev/call-dispose-on-component-reinstantiation
github/fork/astagi/fix/tree-shake-modules
github/fork/compnerd/dark-accordion-icon
github/fork/derSascha/dropdown-dont-close-on-input-click
github/fork/dev-ph1l/main
github/fork/donquixote/issue-33861-utl-mixin
github/fork/florianlacreuse/mixin-make-row-gutter-y
github/fork/gregorw/main
github/fork/iteggmbh/transitionend-dispose-race
github/fork/jdelStrother/patch-1
github/fork/jonnysp/form-floating
github/fork/jonnysp/independent-offcanvas
github/fork/jonnysp/theme-dark-on-card-and-modal-fix
github/fork/josefdlange/floating-label-placeholder-opacity
github/fork/julien-deramond/enhance-change-version.js
github/fork/julien-deramond/main-jd-fix-offset-content
github/fork/julien-deramond/main-jd-issue-with-utitlies
github/fork/julien-deramond/main-xmr-pa11y-ci-jd-add-hideElements
github/fork/kyletsang/fix-tooltip-padding
github/fork/lacutah/CheckboxCenteringDocumentation
github/fork/lekoala/patch-3
github/fork/louismaximepiton/main-kld-lmp-collapse-proposal
github/fork/louismaximepiton/main-lmp-card-inner-border-radius-fix
github/fork/louismaximepiton/main-lmp-carousel-multiple-images
github/fork/louismaximepiton/main-lmp-css-var-init
github/fork/louismaximepiton/main-lmp-disabled-floating-label-fix
github/fork/louismaximepiton/main-lmp-input-range-fix
github/fork/louismaximepiton/main-lmp-shift-color
github/fork/louismaximepiton/main-lmp-table-active-tr-fix
github/fork/maciek-szn/switch
github/fork/michael-roth/feature/19964-multiple-tab-targets
github/fork/mistic100/dom-utils
github/fork/nkdas91/accordion
github/fork/nstungcom/fix-missing-modal-open-class
github/fork/oraliahdz/animation-utilities
github/fork/pine3ree/patch-7
github/fork/pouwerkerk/unindent-scss-docs-shortcode
github/fork/smares/smares-no-scolling-on-modal-close
github/fork/tgm-git/patch-1
gs-forms
gs-toasts-with-animated-progress-bar
gs/add-history-helper
gs/change-version-dir-on-docs
gs/data-must-set-onlu-one-instance
gs/docs/fix-drop-down-error
gs/event-handler-2
gs/make-docs-js-build
gs/make-simple-attribute-toggler
gs/popover-fix-doc
gs/provide-steConfig-method
gs/scrollspy-smoothscroll-option-use-browser-history
gs/streamline-jqueryInterface
gs/support-drop-down-in-navbar
gs/test-js-generic-trigger
gs/try-web-components
gs/tweak-collapse-js-selector
gs/use-event-handler-in-cocmponent
gs/use-rollup-replace-for-version
jo-docs-thanks-page
jo-ssr-friendly
logical-props-spacing-utils
main-fod-disabled-form-check-label
main-fod-nested-accordion
main-fod-simpler-table-structure
main-fod-table-separator
main-fod-utilities-contrast
main-jd-abbr-title
main-jd-add-chips
main-jd-add-doc-for-sass-custom-colors
main-jd-add-enable-host-to-handle-web-components
main-jd-browserstack-fine-tune
main-jd-browserstack-updates
main-jd-docs-consistent-usage-of-css-sections-step-2
main-jd-fix-docs-headers-in-white
main-jd-fix-highlight-docs-border-radius
main-jd-fix-placeholder-color-background-params-for-img-markup
main-jd-glossary-experiment
main-jd-postcss-drop-empty-css-vars
main-jd-proto-doc-astro
main-jd-skip-navigation-component
main-jd-stackblitz-for-examples
main-jd-upgrade-browserlistrc
main-jd-use-host
main-lmp-dark-theme-customization
main-lmp-handle-scroll-target
main-lmp-tab-fix
main-mc-opensearch
main-xmr-bundlewatch-action
main-xmr-eslint-plugin-compat
main-xmr-hugo-docs-vendor
main-xmr-hugo-rm-ver
main-xmr-linkinator-prod
main-xmr-min-mangle
main-xmr-pa11y-ci
more-darkmode-examples
nested-dropdowns
patrickhlauke-issue37428
patrickhlauke-use-of-color-tweaks
pr/34102
pr/37590
previous-next-docs-links
sticky-thead
utilities-functions-mixin
v530-dev
v6-postcss-custom-media
v6-spinner-dots
v6/gs/use-floating-ui-in-place-of-popper
xmr/dev
xmr/docs-png
xmr/docs-svgs
xmr/hugo-reorg-files
xmr/js-2
xmr/markdownlint
xmr/prepare-530-alpha2
xmr/xo
v5.3.0-alpha1
v5.2.3
v5.2.2
v5.2.1
v5.2.0
v5.2.0-beta1
v5.1.3
v5.1.2
v5.1.1
v5.1.0
v5.0.2
v5.0.1
v5.0.0
v5.0.0-beta3
v5.0.0-beta2
v5.0.0-beta1
v5.0.0-alpha3
v5.0.0-alpha2
v5.0.0-alpha1
5 merge requests
!31948
Examples/Floating-labels: fix bad behavior with autofill
,
!30064
test
,
!29779
Responsive sizing
,
!28882
fix custom-select-indicator in IE10
,
!28721
Hot test
Changes
5
Hide whitespace changes
Inline
Side-by-side
Showing
5 changed files
js/src/collapse.js
+4
-4
js/src/collapse.js
js/src/dropdown.js
+4
-4
js/src/dropdown.js
js/src/modal.js
+1
-1
js/src/modal.js
js/src/scrollspy.js
+3
-3
js/src/scrollspy.js
js/src/tab.js
+2
-2
js/src/tab.js
with
14 additions
and
14 deletions
+14
-14
js/src/collapse.js
+
4
-
4
View file @
fee11fd7
...
...
@@ -74,11 +74,11 @@ class Collapse {
`[data-toggle="collapse"][data-target="#
${
element
.
id
}
"]`
))
const
toggleList
=
Util
.
makeArray
(
document
.
querySelectorAll
(
Selector
.
DATA_TOGGLE
))
const
toggleList
=
Util
.
makeArray
(
SelectorEngine
.
find
(
Selector
.
DATA_TOGGLE
))
for
(
let
i
=
0
,
len
=
toggleList
.
length
;
i
<
len
;
i
++
)
{
const
elem
=
toggleList
[
i
]
const
selector
=
Util
.
getSelectorFromElement
(
elem
)
const
filterElement
=
Util
.
makeArray
(
document
.
querySelectorAll
(
selector
))
const
filterElement
=
Util
.
makeArray
(
SelectorEngine
.
find
(
selector
))
.
filter
((
foundElem
)
=>
foundElem
===
element
)
if
(
selector
!==
null
&&
filterElement
.
length
)
{
...
...
@@ -130,7 +130,7 @@ class Collapse {
let
activesData
if
(
this
.
_parent
)
{
actives
=
Util
.
makeArray
(
this
.
_parent
.
querySelectorAll
(
Selector
.
ACTIVES
))
actives
=
Util
.
makeArray
(
SelectorEngine
.
find
(
Selector
.
ACTIVES
,
this
.
_parent
))
.
filter
((
elem
)
=>
{
if
(
typeof
this
.
_config
.
parent
===
'
string
'
)
{
return
elem
.
getAttribute
(
'
data-parent
'
)
===
this
.
_config
.
parent
...
...
@@ -343,7 +343,7 @@ class Collapse {
static
_getTargetFromElement
(
element
)
{
const
selector
=
Util
.
getSelectorFromElement
(
element
)
return
selector
?
document
.
querySelector
(
selector
)
:
null
return
selector
?
SelectorEngine
.
findOne
(
selector
)
:
null
}
static
_collapseInterface
(
element
,
config
)
{
...
...
This diff is collapsed.
Click to expand it.
js/src/dropdown.js
+
4
-
4
View file @
fee11fd7
...
...
@@ -152,7 +152,7 @@ class Dropdown {
* Popper - https://popper.js.org
*/
if
(
typeof
Popper
===
'
undefined
'
)
{
throw
new
TypeError
(
'
Bootstrap
\'
s dropdowns require Popper.js (https://popper.js.org
/
)
'
)
throw
new
TypeError
(
'
Bootstrap
\'
s dropdowns require Popper.js (https://popper.js.org)
'
)
}
let
referenceElement
=
this
.
_element
...
...
@@ -286,7 +286,7 @@ class Dropdown {
const
parent
=
Dropdown
.
_getParentFromElement
(
this
.
_element
)
if
(
parent
)
{
this
.
_menu
=
parent
.
querySelector
(
Selector
.
MENU
)
this
.
_menu
=
SelectorEngine
.
findOne
(
Selector
.
MENU
,
parent
)
}
}
return
this
.
_menu
...
...
@@ -442,7 +442,7 @@ class Dropdown {
const
selector
=
Util
.
getSelectorFromElement
(
element
)
if
(
selector
)
{
parent
=
document
.
querySelector
(
selector
)
parent
=
SelectorEngine
.
findOne
(
selector
)
}
return
parent
||
element
.
parentNode
...
...
@@ -482,7 +482,7 @@ class Dropdown {
return
}
const
items
=
Util
.
makeArray
(
parent
.
querySelectorAll
(
Selector
.
VISIBLE_ITEMS
))
const
items
=
Util
.
makeArray
(
SelectorEngine
.
find
(
Selector
.
VISIBLE_ITEMS
,
parent
))
if
(
!
items
.
length
)
{
return
...
...
This diff is collapsed.
Click to expand it.
js/src/modal.js
+
1
-
1
View file @
fee11fd7
...
...
@@ -246,7 +246,7 @@ class Modal {
this
.
_element
.
setAttribute
(
'
aria-modal
'
,
true
)
if
(
this
.
_dialog
.
classList
.
contains
(
ClassName
.
SCROLLABLE
))
{
this
.
_dialog
.
querySelector
(
Selector
.
MODAL_BODY
).
scrollTop
=
0
SelectorEngine
.
findOne
(
Selector
.
MODAL_BODY
,
this
.
_dialog
).
scrollTop
=
0
}
else
{
this
.
_element
.
scrollTop
=
0
}
...
...
This diff is collapsed.
Click to expand it.
js/src/scrollspy.js
+
3
-
3
View file @
fee11fd7
...
...
@@ -118,7 +118,7 @@ class ScrollSpy {
this
.
_scrollHeight
=
this
.
_getScrollHeight
()
const
targets
=
Util
.
makeArray
(
document
.
querySelectorAll
(
this
.
_selector
))
const
targets
=
Util
.
makeArray
(
SelectorEngine
.
find
(
this
.
_selector
))
targets
.
map
((
element
)
=>
{
...
...
@@ -126,7 +126,7 @@ class ScrollSpy {
const
targetSelector
=
Util
.
getSelectorFromElement
(
element
)
if
(
targetSelector
)
{
target
=
document
.
querySelector
(
targetSelector
)
target
=
SelectorEngine
.
findOne
(
targetSelector
)
}
if
(
target
)
{
...
...
@@ -284,7 +284,7 @@ class ScrollSpy {
}
_clear
()
{
Util
.
makeArray
(
document
.
querySelectorAll
(
this
.
_selector
))
Util
.
makeArray
(
SelectorEngine
.
find
(
this
.
_selector
))
.
filter
((
node
)
=>
node
.
classList
.
contains
(
ClassName
.
ACTIVE
))
.
forEach
((
node
)
=>
node
.
classList
.
remove
(
ClassName
.
ACTIVE
))
}
...
...
This diff is collapsed.
Click to expand it.
js/src/tab.js
+
2
-
2
View file @
fee11fd7
...
...
@@ -106,7 +106,7 @@ class Tab {
}
if
(
selector
)
{
target
=
document
.
querySelector
(
selector
)
target
=
SelectorEngine
.
findOne
(
selector
)
}
this
.
_activate
(
...
...
@@ -193,7 +193,7 @@ class Tab {
const
dropdownElement
=
SelectorEngine
.
closest
(
element
,
Selector
.
DROPDOWN
)
if
(
dropdownElement
)
{
Util
.
makeArray
(
dropdownElement
.
querySelectorAll
(
Selector
.
DROPDOWN_TOGGLE
))
Util
.
makeArray
(
SelectorEngine
.
find
(
Selector
.
DROPDOWN_TOGGLE
))
.
forEach
((
dropdown
)
=>
dropdown
.
classList
.
add
(
ClassName
.
ACTIVE
))
}
...
...
This diff is collapsed.
Click to expand it.
Write
Preview
Supports
Markdown
0%
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment
Menu
Explore
Projects
Groups
Snippets