Skip to content
GitLab
  1. 21 Apr, 2017 1 commit
  3. 20 Apr, 2017 4 commits
  5. 19 Apr, 2017 2 commits
  7. 18 Apr, 2017 3 commits
  9. 17 Apr, 2017 1 commit
    • Patrick H. Lauke's avatar
      Fix carousel "hover" behavior on touch-enabled devices · 6ae5fb12
      Patrick H. Lauke authored 
      * Add carousel mouse listeners even if touch events enabled

- touch events are enabled not just on "mobile", just also on
touch-enabled desktop/laptop devices; additionally, it's possible to
pair a mouse with traditionally touch-only devices (e.g. Android
phones/tablets); currently, in these situations the carousel WON'T pause
even when using a mouse

* Restart cycle after touchend

as `mouseenter` is fired as part of the touch compatibility events, the
previous change results in carousels which cycle until the user
tapped/interacted with them. after that they stop cycling (as
`mouseleave` is not sent to the carousel after user scrolled/tapped
away).
this fix resets the cycling after `touchend` - essentially returning
to the previous behavior, where on touch the carousel essentially never
pauses, but now with the previous fix it at least pauses correctly for
mouse users on touch-enabled devices.
includes documentation for this new behavior.
      6ae5fb12
  11. 16 Apr, 2017 5 commits
    • Patrick H. Lauke's avatar
      Rewrite getting started/accessibility docs · 7ffb61ac
      Patrick H. Lauke authored 
      A long overdue rewrite of the accessibility section - instead of the few
snippets of strangely superficial and out-of-context advice (skip links,
use correct heading levels), this tries to answer some of the
fundamental questions about "is Bootstrap accessible", with emphasis on
the fact that the final result will depend in large part on what BS is
applied to/on (since BS relies on the markup etc authored by
developers). This also sets out our ambition to have things work for
keyboard and assistive tech users, and that we strive to make all our
examples etc accessible and semantic.

* Changes based on @mdo's feedback
      7ffb61ac
    • Patrick Yeo's avatar
      Rename variable $input-border-focus to $input-border-color-focus (#22413) · dd0ce3e4
      Patrick Yeo authored 
      * Rename variable $input-border-focus to $input-border-color-focus
* Rename variables $pagination-hover-border, $pagination-active-border, $pagination-disabled-border to $pagination-hover-border-color, $pagination-active-border-color, $pagination-disabled-border-color, respectively
* Rename variables $state-*-border to $state-*-border-color, respectively
* Rename variables $alert-*-border to $alert-*-border-color
* Rename $list-group-active-border to $list-group-active-border-color
* Rename $table-inverse-border to $table-inverse-border-color
* Rename $btn-*-border to $btn-*-border-color
* Rename $navbar-*-toggler-border to $navbar-*-toggler-border-color
      dd0ce3e4
    • Mark Otto's avatar
      Prevent long words in `.card-title`s from breaking auto layout · 20756104
      Mark Otto authored
      20756104
    • Patrick H. Lauke's avatar
      Make "Copy" buttons actual buttons · ea1d69c6
      Patrick H. Lauke authored 
      This makes them keyboard-accessible. For mouse users, the only change
here is that the focus outline will remain on the button once clicked
(in future, this can be solved with :focus-ring, but for now this would
require a polyfill). the tooltip is explicitly hidden on `mouseleave`,
so even though the `<button>` retains focus after clicking, the tooltip
won't stay visible once mouse user moves away.
the mouse hover styles have explicitly not been make to also apply to
:focus, so as to minimise the visual impact for
mouse users (though the tooltip remains visible)
 - but due to the default outline and the custom tooltip, it
should be fairly clear when keyboard users set focus to a copy button
too.
      ea1d69c6
    • Mark Otto's avatar
      grunt · bc0cf36d
      Mark Otto authored
      bc0cf36d
  13. 14 Apr, 2017 1 commit
    • Patrick H. Lauke's avatar
      Replace dropdown backdrop hack with cleaner JS-only hack · 6d64afe5
      Patrick H. Lauke authored 
      * Replace backdrop with simple noop mouse listener

As discussed in https://github.com/twbs/bootstrap/pull/22422 the current
approach of injecting a backdrop (to work around iOS' broken event
delegation for the `click` event) has annoying consequences on
touch-enabled laptop/desktop devices.
Instead of a backdrop `<div>`, here we simply add extra empty/noop
mouse listeners to the immediate children of `<body>` (and remove
them when the dropdown is closed) in order to force iOS to properly
bubble a `click` resulting from a tap (essentially, method 2 from
https://www.quirksmode.org/blog/archives/2014/02/mouse_event_bub.html)
This is sufficient (except in rare cases where the user does manage to tap
on the body itself, rather than any child elements of body - which is not
very likely in an iOS phone/tablet scenario for most layouts) to get iOS to
get a grip and do the correct event bubbling/delegation, meaning the regular
"click" event will bubble back to the `<body>` when tapping outside of the dropdown,
and the dropdown will close properly (just like it already does, even without
this fix, in non-iOS touchscreen devices/browsers, like Chrome/Android and
Windows on a touch laptop).
This approach, though a bit hacky, has no impact on the DOM structure, and
has no unforeseen side effects on touch-enabled laptops/desktops. And crucially,
it works just fine in iOS.

* Remove dropdown backdrop styles

* Update doc for dropdowns and touch-enabled devices
      6d64afe5
  15. 13 Apr, 2017 3 commits
  17. 12 Apr, 2017 5 commits
  19. 11 Apr, 2017 3 commits
  21. 10 Apr, 2017 5 commits
  23. 09 Apr, 2017 7 commits