Skip to content
GitLab
  1. 14 May, 2017 1 commit
  3. 28 Apr, 2017 1 commit
  5. 26 Apr, 2017 1 commit
  7. 25 Apr, 2017 1 commit
  9. 22 Apr, 2017 2 commits
  11. 21 Apr, 2017 1 commit
  13. 20 Apr, 2017 4 commits
  15. 17 Apr, 2017 1 commit
    • Patrick H. Lauke's avatar
      Fix carousel "hover" behavior on touch-enabled devices · 6ae5fb12
      Patrick H. Lauke authored 
      * Add carousel mouse listeners even if touch events enabled

- touch events are enabled not just on "mobile", just also on
touch-enabled desktop/laptop devices; additionally, it's possible to
pair a mouse with traditionally touch-only devices (e.g. Android
phones/tablets); currently, in these situations the carousel WON'T pause
even when using a mouse

* Restart cycle after touchend

as `mouseenter` is fired as part of the touch compatibility events, the
previous change results in carousels which cycle until the user
tapped/interacted with them. after that they stop cycling (as
`mouseleave` is not sent to the carousel after user scrolled/tapped
away).
this fix resets the cycling after `touchend` - essentially returning
to the previous behavior, where on touch the carousel essentially never
pauses, but now with the previous fix it at least pauses correctly for
mouse users on touch-enabled devices.
includes documentation for this new ...
      6ae5fb12
  17. 16 Apr, 2017 1 commit
  19. 14 Apr, 2017 1 commit
    • Patrick H. Lauke's avatar
      Replace dropdown backdrop hack with cleaner JS-only hack · 6d64afe5
      Patrick H. Lauke authored 
      * Replace backdrop with simple noop mouse listener

As discussed in https://github.com/twbs/bootstrap/pull/22422 the current
approach of injecting a backdrop (to work around iOS' broken event
delegation for the `click` event) has annoying consequences on
touch-enabled laptop/desktop devices.
Instead of a backdrop `<div>`, here we simply add extra empty/noop
mouse listeners to the immediate children of `<body>` (and remove
them when the dropdown is closed) in order to force iOS to properly
bubble a `click` resulting from a tap (essentially, method 2 from
https://www.quirksmode.org/blog/archives/2014/02/mouse_event_bub.html)
This is sufficient (except in rare cases where the user does manage to tap
on the body itself, rather than any child elements of body - which is not
very likely in an iOS phone/tablet scenario for most layouts) to get iOS to
get a grip and do the correct event bubbling/delegation, meaning the regular
"click" event w...
      6d64afe5
  21. 12 Apr, 2017 2 commits
  23. 11 Apr, 2017 1 commit
  25. 10 Apr, 2017 2 commits
    • Patrick H. Lauke's avatar
      Fix collapse.js aria-expanded behavior · 18e87042
      Patrick H. Lauke authored 
      * Remove aria-expanded from collapse.js target element

aria-expanded="true"/aria-expanded="false" only applies to the trigger,
not the element that is being expanded/collapsed.

* Tweak collapse.js accessibility section

...to make it clearer that the aria-expanded attribute always just goes
on the control.

* Fix collapse.js unit tests

- reword some of the text to make it clear we're checking behavior of
trigger/control
- move incorrect aria-expanded out of the <div>s and to the actual
trigger/control <a>s
- fix incorrect test assertion text output false -> true
      18e87042
    • Patrick H. Lauke's avatar
      Only change aria-pressed if it's not an input-based radio or checkbox group · 3f6e1faf
      Patrick H. Lauke authored 
      * Only change aria-pressed if it's not an input-based radio or checkbox group

aria-pressed="true"/aria-pressed="false" is really only useful for
making on/off toggles out of, say, `<button>` elements. the attribute is
useless (and potentially confusing/conflicting) on, say, `<label>`
elements for an existing `<input type="radio">` or similar.

* Add unit test for buttons.js and radio/checkbox inputs in button groups
      3f6e1faf
  27. 09 Apr, 2017 1 commit
  29. 08 Apr, 2017 1 commit
  31. 03 Apr, 2017 1 commit
  33. 02 Apr, 2017 3 commits
  35. 31 Mar, 2017 1 commit
  37. 28 Mar, 2017 5 commits
  39. 27 Mar, 2017 1 commit
  41. 26 Mar, 2017 1 commit
  43. 24 Mar, 2017 2 commits
  45. 23 Mar, 2017 2 commits
  47. 22 Mar, 2017 1 commit
  49. 21 Mar, 2017 2 commits