Skip to content
GitLab
  1. 12 Jul, 2020 7 commits
  3. 11 Jul, 2020 6 commits
    • Patrick H. Lauke's avatar
      Docs: forms accessibility cleanup (#31114) · eeb73e0c
      Patrick H. Lauke authored 
      * Expand on disabled fieldsets and faked buttons

include further advice/information on how to disable faked buttons for keyboard/AT users

* Centralise accessible name advice in forms overview

seems odd to only mention (separately) label, aria-label etc in input-group and layout. the advice is just as pertinent in other sections like select. checks only skims over this.

moving this, in expanded form, into the overview section itself. adding a specific cross-reference (just because they are easily left with no accname at all) in the checks page.

* Change warning about accessibility, modify server-side example

- paradoxically, due to our current problems with validation (see #28414

) and the fact that browsers seem to have improved in this area for the most part, it's now actually better to use browser-native validation
- added explicit `id` and `aria-describedby` association to at least the server-side form error messages, to show how it should be done properly, and expanded the prose for that explaining this.

* Replace `.sr-only` with `.visually-hidden` in new addition

* Copy edits for clarity in parenthetical

* Copy and formatting tweaks

- Wordsmithing here and there
- Turns some hyphens into em dashes
- Turns a long running comma separated list into an unordered list
- Rearranges some copy just a bit

Co-authored-by: default avatarMark Otto <markd.otto@gmail.com>
      eeb73e0c
    • Florian Lacreuse's avatar
      Fix docs sass importing example. · 19b5908b
      Florian Lacreuse authored
      19b5908b
    • Mark Otto's avatar
      Add null variables for nav-link · 2b4db023
      Mark Otto authored 
      Replaces #30498 by adding four new null default variables for .nav-link. Doesn't carry over font-style from the original PR though since that's rarely used, at least by default Bootstrap. Nullifies all values from that PR, too, since we count on some basic inheritance here and don't need color by default.
      2b4db023
    • Rohit Sharma's avatar
      Clear timeout before showing the toast (#31155) · f6348f6c
      Rohit Sharma authored 
      
* clear timeout before showing the toast

* Add unit test

* Remove the check for timeout

* Check for clearTimeout to have been called

Co-authored-by: default avatarXhmikosR <xhmikosr@gmail.com>
      f6348f6c
    • Mark Otto's avatar
      Update layout.md · 6acdfdbf
      Mark Otto authored
      6acdfdbf
    • Rohit Sharma's avatar
      Single line example for inline forms · 6eaa36fb
      Rohit Sharma authored
      6eaa36fb
  5. 10 Jul, 2020 5 commits
  7. 07 Jul, 2020 4 commits
  9. 06 Jul, 2020 3 commits
  11. 03 Jul, 2020 4 commits
    • Martijn Cuppens's avatar
      Fix sidebar jump (#31232) · 7cedb8ee
      Martijn Cuppens authored
      7cedb8ee
    • Patrick H. Lauke's avatar
      Rename `sr-only`/`sr-only-focusable` (#31139) · 10690dd3
      Patrick H. Lauke authored 
      
* Rename `sr-only`/`sr-only-focusable`

To be more representative of the fact that these are not necessarily "screen reader" specific, but actually apply to assistive technologies in general (and also things like Alexa/Siri/etc). Goes hand-in-hand with #31133

Co-authored-by: default avatarXhmikosR <xhmikosr@gmail.com>
      10690dd3
    • Patrick H. Lauke's avatar
      Docs: improve/expand button documentation (#31093) · 0a6cf903
      Patrick H. Lauke authored 
      * Docs: improve/expand button documentation

- since we're not doing the disabled cursor thing anymore anyway, remove confusing/unnecessary mention for link-based disabled buttons
- make the disabled toggle example using a link actually follow the preceding advice of also having `tabindex="-1"` and `aria-disabled="true"`
- tweak the link functionality callout to also still mention `aria-disabled` to reinforce the idea
- tweak toggle state description (not just `<button>`s, but also links etc...so just remove mention of `<button>` there; also reinforce accessibility aspect once more)
- add a new callout that cross-references checkbox-based toggles, and what the similarity/difference between them is
- add a matching cross-reference callout to the checkbox-based toggle buttons page

* Update link to now renamed checks-radios.md
      0a6cf903
    • Patrick H. Lauke's avatar
      Docs: clarify that pointer events classes don't affect keyboard interaction (#31134) · 386f9e32
      Patrick H. Lauke authored 
      * Docs: clarify that pointer events classes don't affect keyboard interaction

* Neutralise example links that are `pe-none`
      386f9e32
  13. 01 Jul, 2020 6 commits
  15. 30 Jun, 2020 5 commits