Skip to content
GitLab
  1. 16 Apr, 2017 1 commit
  3. 14 Apr, 2017 1 commit
    • Patrick H. Lauke's avatar
      Replace dropdown backdrop hack with cleaner JS-only hack · 6d64afe5
      Patrick H. Lauke authored 
      * Replace backdrop with simple noop mouse listener

As discussed in https://github.com/twbs/bootstrap/pull/22422 the current
approach of injecting a backdrop (to work around iOS' broken event
delegation for the `click` event) has annoying consequences on
touch-enabled laptop/desktop devices.
Instead of a backdrop `<div>`, here we simply add extra empty/noop
mouse listeners to the immediate children of `<body>` (and remove
them when the dropdown is closed) in order to force iOS to properly
bubble a `click` resulting from a tap (essentially, method 2 from
https://www.quirksmode.org/blog/archives/2014/02/mouse_event_bub.html)
This is sufficient (except in rare cases where the user does manage to tap
on the body itself, rather than any child elements of body - which is not
very likely in an iOS phone/tablet scenario for most layouts) to get iOS to
get a grip and do the correct event bubbling/delegation, meaning the regular
"click" event will bubble back to the `<body>` when tapping outside of the dropdown,
and the dropdown will close properly (just like it already does, even without
this fix, in non-iOS touchscreen devices/browsers, like Chrome/Android and
Windows on a touch laptop).
This approach, though a bit hacky, has no impact on the DOM structure, and
has no unforeseen side effects on touch-enabled laptops/desktops. And crucially,
it works just fine in iOS.

* Remove dropdown backdrop styles

* Update doc for dropdowns and touch-enabled devices
      6d64afe5
  5. 12 Apr, 2017 2 commits
  7. 11 Apr, 2017 1 commit
  9. 10 Apr, 2017 2 commits
    • Patrick H. Lauke's avatar
      Fix collapse.js aria-expanded behavior · 18e87042
      Patrick H. Lauke authored 
      * Remove aria-expanded from collapse.js target element

aria-expanded="true"/aria-expanded="false" only applies to the trigger,
not the element that is being expanded/collapsed.

* Tweak collapse.js accessibility section

...to make it clearer that the aria-expanded attribute always just goes
on the control.

* Fix collapse.js unit tests

- reword some of the text to make it clear we're checking behavior of
trigger/control
- move incorrect aria-expanded out of the <div>s and to the actual
trigger/control <a>s
- fix incorrect test assertion text output false -> true
      18e87042
    • Patrick H. Lauke's avatar
      Only change aria-pressed if it's not an input-based radio or checkbox group · 3f6e1faf
      Patrick H. Lauke authored 
      * Only change aria-pressed if it's not an input-based radio or checkbox group

aria-pressed="true"/aria-pressed="false" is really only useful for
making on/off toggles out of, say, `<button>` elements. the attribute is
useless (and potentially confusing/conflicting) on, say, `<label>`
elements for an existing `<input type="radio">` or similar.

* Add unit test for buttons.js and radio/checkbox inputs in button groups
      3f6e1faf
  11. 09 Apr, 2017 1 commit
  13. 08 Apr, 2017 1 commit
  15. 03 Apr, 2017 1 commit
  17. 02 Apr, 2017 3 commits
  19. 31 Mar, 2017 1 commit
  21. 28 Mar, 2017 5 commits
  23. 27 Mar, 2017 1 commit
  25. 26 Mar, 2017 1 commit
  27. 24 Mar, 2017 2 commits
  29. 23 Mar, 2017 2 commits
  31. 22 Mar, 2017 1 commit
  33. 21 Mar, 2017 2 commits
  35. 20 Mar, 2017 2 commits
  37. 19 Mar, 2017 4 commits
  39. 18 Mar, 2017 2 commits
  41. 12 Mar, 2017 1 commit
  43. 09 Mar, 2017 1 commit
  45. 08 Mar, 2017 1 commit
  47. 07 Mar, 2017 1 commit