- 09 May, 2016 4 commits
-
-
Pierre-Denis Vanduynslager authored270b3b56
-
Pierre-Denis Vanduynslager authoredfce0af1b
-
Pierre-Denis Vanduynslager authored344c0b5b
-
Pierre-Denis Vanduynslager authored8a26268c
-
Created by: pvdlg
Per migration documentation in https://github.com/twbs/bootstrap/commit/4d8d8bdab4b0e2931fcf92ce30d772b05a989434:
- Rebuilt dropdown styles and markup to provide easy, built-in support for
<a>
and<button>
based dropdown items.- Dropdown items now require
.dropdown-item
.
Per https://github.com/twbs/bootstrap/issues/19034#issuecomment-179749958 role="menu" should have been dropped.
This PR:
role="menu"
or role="listbox"
and rely on the class dropdown-menu
insteada
element for the dropdown-item and rely on the class dropdown-item
insteadli
elementsAll this problems affected only the keyboard navigation in the dropdown. With this modification the javascript now matches the markup in the documentation. The keyboard navigation works again now in dropdowns.