Skip to content
GitLab
    • Explore Projects Groups Snippets
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !20349

v4: Follow-up grid fixes

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Mark Otto requested to merge v4-grid-fixes into v4-dev 8 years ago
  • Overview 0
  • Commits 3
  • Pipelines 0
  • Changes 3

This PR restores that v3-like grid system goodness that I fucked up in #19099.

The mistake I made in that PR was simplifying things too much; the single mixin approach meant every grid tier class received their position, min-height, and padding-left/-right within their media queries. With this PR, we're back to setting all that grid column prep separately, outside the media queries, for a simpler and more familiar approach. The two grid mixins are now make-col-prep and make-col.

As part of this, I've tried to prevent the need for an xs class for the flexbox grid with a new width: 100% on that grid prep mixin. This "initial" width is then overridden by the flex values for each grid class within each grid media query. I mention this because it's the whole reason I went down the path I did with these mixins in #19099.

Worth noting I've also updated the docs the grid mixins accordingly.

Fixes #19803 (closed) and #20349.

/cc @twbs/team for sanity checks.

Activity

Please register or sign in to reply

There are currently no pipelines.

To run a merge request pipeline, the jobs in the CI/CD configuration file must be configured to run in merge request pipelines.

0 Assignees
None
Assign to
0 Reviewers
None
Request review from
Labels
2
css v4
2
css v4
    Assign labels
  • Manage project labels

Milestone
v4.0.0-alpha.3
v4.0.0-alpha.3
None
Time tracking
No estimate or time spent
Lock merge request
Unlocked
1
1 participant
Mark Otto
Reference: twbs/bootstrap!20349
Source branch: v4-grid-fixes

Menu

Explore Projects Groups Snippets